Jump to content
  • 0

Sarah card bonus


Last

Question


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  20
  • Reputation:   4
  • Joined:  04/18/12
  • Last Seen:  

In this fix https://github.com/rathena/rathena/commit/252689b51c63db46b8127a75602a840fc006ba0b# sarah card bonus was changed to bAbsorbDmgMaxHP2,40
but in the item db is still 
bAbsorbDmgMaxHP,100

 

    AegisName: Sarah_Card
    Name: Sarah Card
    Type: Card
    Buy: 20
    Weight: 10
    Locations:
      Armor: true
    Flags:
      BuyingStore: true
      DropEffect: CLIENT
    Script: |
      bonus bAbsorbDmgMaxHP,100;

Is this on porpuse? 

Link to comment
Share on other sites

2 answers to this question

Recommended Posts

  • 0

  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.01
  • Content Count:  82
  • Reputation:   7
  • Joined:  12/29/18
  • Last Seen:  

AS you can see ----- > image.png.e45b4789490c865273d5e97a4bfb9157.png
 

wants to merge

That means it's not yet merged into the main rathena branch, I haven't read the commit details, but maybe it's still awaiting confirmation.

Edited by Fluxion
typo
Link to comment
Share on other sites

  • 0

  • Group:  Members
  • Topic Count:  49
  • Topics Per Day:  0.01
  • Content Count:  1509
  • Reputation:   227
  • Joined:  08/03/12
  • Last Seen:  

13 hours ago, Last said:

In this fix https://github.com/rathena/rathena/commit/252689b51c63db46b8127a75602a840fc006ba0b# sarah card bonus was changed to bAbsorbDmgMaxHP2,40
but in the item db is still 
bAbsorbDmgMaxHP,100

 

    AegisName: Sarah_Card
    Name: Sarah Card
    Type: Card
    Buy: 20
    Weight: 10
    Locations:
      Armor: true
    Flags:
      BuyingStore: true
      DropEffect: CLIENT
    Script: |
      bonus bAbsorbDmgMaxHP,100;

Is this on porpuse? 

https://github.com/rathena/rathena/pull/6281

This pull request still open, means its not merged in master yet.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...