How to add Endure, Auto Guard and Reflect Shield stateicon to character under influence of devotion?

[Fluxion]

Hi rAthena, long time no see!!

After a few hours of research, i found that devotion skill give shield buff and other buff like Endure.
I don't know if i have a real information but according to iro wiki and ratemyserver.
 

Quote

Ratemyserver : (https://ratemyserver.net/index.php?page=skill_db&jid=14)
If the caster has any self casted, class native enhancements on him, e.g. Endure (Endure transfer is disabled in WoE), Providence or Reflect Shield, the party member(s) will share these benefits, too.

iRO WikiI: (https://irowiki.org/classic/Sacrifice)

• Certain abilities function through Sacrifice: Guard, Shield Reflect, and Defending Aura. Guard works as if the sacrificed target had the skill active, also inducing physical attack delay when activated. Shield Reflect only works on melee skills when applied through Sacrifice. This includes Guillotine Fist, as well as Arrow Shower cast by a monster. Defending Aura currently will slow all sacrificed targets when activated, but only apply a reduced damage reduction compared to the 80% reduction on the caster.

So I tried adding a stateicon for the Devotion skill, successful as you can see.


And I said to myself ok, now I'm going to see if the icons for Endure, Auto Guard and Reflect Shield appears when I am under the influence of Devotion and it looks like only the Defender icon is displayed. Could someone have an explanation for me?


Thank you for the time you take to answer me!

[Gidz Cross]

Okay. To mirror Endure to devoted party

status.c
look for this line:
 

	case SC_IMPOSITIO:
	case SC_KAAHI:
		//These status changes always overwrite themselves even when a lower level is cast
		status_change_end(bl, type, INVALID_TIMER);
		break;
	case SC_ENDURE:
		if (sd && sd->special_state.no_walk_delay)
			return 1;
		break;
	}

change it to

	case SC_IMPOSITIO:
	case SC_KAAHI:
		//These status changes always overwrite themselves even when a lower level is cast
		status_change_end(bl, type, INVALID_TIMER);
		break;
	case SC_ENDURE:
		if (sd) {
			struct map_session_data *tsd;
			int i;
			for (i = 0; i < MAX_DEVOTION; i++) { // See if there are devoted characters, and pass the status to them. [Skotlex]
				if (sd->devotion[i] && (tsd = map_id2sd(sd->devotion[i])))
					status_change_start(src,&tsd->bl,type,10000,val1,val2,val3,val4,tick,SCSTART_NOAVOID);
			}
		}
		if (sd && sd->special_state.no_walk_delay)
			return 1;
		break;
	}

For the reflect shield

status.c
look for this line:
 

		case SC_PROVIDENCE:
			val2 = val1*5; // Race/Ele resist
			break;
		case SC_REFLECTSHIELD:
			val2 = 10+val1*3; // %Dmg reflected
			// val4 used to mark if reflect shield is an inheritance bonus from Devotion
			if( !(flag&SCSTART_NOAVOID) && (bl->type&(BL_PC|BL_MER)) ) {
				struct map_session_data *tsd;
				if( sd ) {
					int i;
					for( i = 0; i < MAX_DEVOTION; i++ ) {
						if( sd->devotion[i] && (tsd = map_id2sd(sd->devotion[i])) )
							status_change_start(src,&tsd->bl, type, 10000, val1, val2, 0, 1, tick, SCSTART_NOAVOID|SCSTART_NOICON);
					}
				}
				else if( bl->type == BL_MER && ((TBL_MER*)bl)->devotion_flag && (tsd = ((TBL_MER*)bl)->master) )
					status_change_start(src,&tsd->bl, type, 10000, val1, val2, 0, 1, tick, SCSTART_NOAVOID|SCSTART_NOICON);
			}

change it to
 

		case SC_PROVIDENCE:
			val2 = val1*5; // Race/Ele resist
			break;
		case SC_REFLECTSHIELD:
			val2 = 10+val1*3; // %Dmg reflected
			// val4 used to mark if reflect shield is an inheritance bonus from Devotion
			if( !(flag&SCSTART_NOAVOID) && (bl->type&(BL_PC|BL_MER)) ) {
				struct map_session_data *tsd;
				if( sd ) {
					int i;
					for( i = 0; i < MAX_DEVOTION; i++ ) {
						if( sd->devotion[i] && (tsd = map_id2sd(sd->devotion[i])) )
							status_change_start(src,&tsd->bl, type, 10000, val1, val2, 0, 1, tick, SCSTART_NOAVOID);
					}
				}
				else if( bl->type == BL_MER && ((TBL_MER*)bl)->devotion_flag && (tsd = ((TBL_MER*)bl)->master) )
					status_change_start(src,&tsd->bl, type, 10000, val1, val2, 0, 1, tick, SCSTART_NOAVOID|SCSTART_NOICON);
			}
			break;

To be honest im not sure about to reflect shield. I might delete some function. But it works upon testing it.  Nevermind. I edit it.

Limitations i found:
The Devo caster should recast (Endure & Reflect Shield)  buffs to appear the state icons to devoted party member.

P.S
I wonder why recasting is needed.

Edited July 24, 2021 by Gidz Cross
modified some stuff

[Gidz Cross]

Use this state icon for devo. Much better!
devotion.tga

 

On 7/26/2021 at 8:00 PM, Frost Diver said:

How to make it work for devotion sir?

It was already declared in SRC so you only need to do it via client. And it's easy.

efstids.lub

EFST_DEVOTION = 60,

stateimgiconinfo.lub

[EFST_IDs.EFST_DEVOTION] = "devotion.tga"

 

finally in stateiconinfo.lub

StateIconList[EFST_IDs.EFST_DEVOTION] = {
    haveTimeLimit = 1,
    posTimeLimitStr = 2,
    descript = {
        { "Devotion", COLOR_TITLE_BUFF },
        { "%s", COLOR_TIME },
        { "Under influence of devotion." },
        { "Received shield buff." },
    }
}

 

[Fluxion]

Its me again! 
I would like to provide additional information regarding my request. 

From the LGP presentation video in @Functor services, we can see what it would seem a High Wizard (we can see Energie Coat on stateicon) which also displays auto guard and reflect shield when under the influence of devotion. Maybe it is my client's problem, but I still haven't found the solution.

[Gidz Cross]

On 7/22/2021 at 10:01 AM, Yuno said:

Hi rAthena, long time no see!!

After a few hours of research, i found that devotion skill give shield buff and other buff like Endure.
I don't know if i have a real information but according to iro wiki and ratemyserver.
 

So I tried adding a stateicon for the Devotion skill, successful as you can see.


And I said to myself ok, now I'm going to see if the icons for Endure, Auto Guard and Reflect Shield appears when I am under the influence of Devotion and it looks like only the Defender icon is displayed. Could someone have an explanation for me?


Thank you for the time you take to answer me!

Oh why didnt i think of this. I have custom state icons too. Like when you stepped on land protector or you cast ecall. But ive done it in a very long time. Now i forgot. I want to help with this. Since the defender state can be mirrored in the devo'ed party. Mirroring Endure and Reflect Shield is doable i guess.

First. I have to refresh my memory how to add customs state icons.

[Fluxion]

Work perfectly! Many thanks once again for this help!

[Frost Diver]

On 7/25/2021 at 4:49 AM, Gidz Cross said:

Use this state icon for devo. Much better!
 

devotion.tga 4.04 kB · 4 downloads

How to make it work for devotion sir?

thanks alot sir for the guides

[Fluxion]

On 7/26/2021 at 2:00 PM, Frost Diver said:

How to make it work for devotion sir?

thanks alot sir for the guides

On stateiconinfo.lub
 

StateIconList[EFST_IDs.EFST_DEVOTION] = {
	haveTimeLimit = 1,
	posTimeLimitStr = 2,
	descript = {
		{ "Devotion", COLOR_TITLE_BUFF },
		{ "%s", COLOR_TIME },
		{ "Under influence of devotion." },
		{ "Received shield buff." },
	}
}

On stateiconimginfo.lub
 

[EFST_IDs.EFST_DEVOTION] = "devotion.tga"

 

Edited September 13, 2021 by Yuno
Missing information for stateiconimginfo.lub

[Frost Diver]

On 9/14/2021 at 1:29 AM, Yuno said:

On stateiconinfo.lub
 

StateIconList[EFST_IDs.EFST_DEVOTION] = {
	haveTimeLimit = 1,
	posTimeLimitStr = 2,
	descript = {
		{ "Devotion", COLOR_TITLE_BUFF },
		{ "%s", COLOR_TIME },
		{ "Under influence of devotion." },
		{ "Received shield buff." },
	}
}

On stateiconimginfo.lub
 

[EFST_IDs.EFST_DEVOTION] = "devotion.tga"

 

Great! Thanks alot