Defining MAX_ITEMID beyond USHRT_MAX

[TheKingDino]

Must we use the macro constant of USHRT_MAX or is LONG_MAX an option? Has anyone messed with this? I simply ask because a lot of new item IDs are unfortunately beyond the 61k limit. They are unnecessarily so, but I'm trying to keep them aligned with the IDs I find on Divine Pride.

 

///Maximum allowed Item ID (range: 1 ~ 65,534)
#define MAX_ITEMID USHRT_MAX

Located in map/itemdb.hpp

Edited May 14, 2020 by TheKingDino

[nitrous]

See https://github.com/rathena/rathena/pull/5141

[HaureN]

going to find out

^ no errors pogU

^ it do let me create a item 310126

 

i created the same script of ygg and it works but i cant make show on client tho

 

nevermore it works LMAO

[TheKingDino]

Awesome. If this works then why are we sticking to the 61k limitation when 6 digit Item IDs have been out for quite a while now?

I'm confused.

[HaureN]

i have no idea...

@Aleos ?

[TheKingDino]

If any developers or people with more knowledge know the answer to this. It'd be very appreciated!

I've currently made this change to my personal server. It runs just fine and I'm able to add 6-digit IDs now. I will let anyone know if I run into any issues.

Edited May 15, 2020 by TheKingDino

[Emistry]

emulator doesnt support it or somewhere doesnt

packets doent support it

etc...

[Ylen X Walker]

On 5/15/2020 at 12:50 AM, HaureN said:

nevermore it works LMAO

How did you made it work? Mine's unknown item.

[HaureN]

thats not a real thing, i mean its not a unknown item but its a "placeholder" in other words once it get the packet cap it start over, in the end of the day its not working yet

you are the best @nitrous

[TheKingDino]

On 5/17/2020 at 4:25 AM, Emistry said:

emulator doesnt support it or somewhere doesnt

packets doent support it

etc...

Really? It's worked fine for me. Did you even test it before saying this?

And even if this is the case what is going to be our answer to the continuous introduction of new items that use item IDs far beyond 65k.

[Emistry]

2 hours ago, TheKingDino said:

Really? It's worked fine for me. Did you even test it before saying this?

Read the date? reply are made on May .. and the PR came out after that?

You're probably hoping that editing that one line would help you solve your issue, but the truth is more work are required to implement the support for above 65k IDs.

and what is the answer? Nitrous already posted that. Implement the PR and help test for the result.