No skills effect after rebalancing class skills

[CyberDevil]

Hi,

a few weeks ago after an update server side that contained this recent commit

https://github.com/rathena/rathena/commit/ea8da71cdda5cddbc05cdc736683487e5c14bf08

concerning the "Rebalancing of 1st/2nd/Transcendent class skills", many skills (but not all) no longer display the graphic effects, for example these skills:

- Poem of Bragi (bard skill)
- Whistle (dancer skill)

The skills work well as always, only that I don't understand how to resolve this issue... the client hasn't undergone any changes in the last few months and these are the various versions I use:
RO client: kRO 28-06-2019
Ragexe (diffed): 2018-06-21aRagexeRE
ROenglishRE: 10 Oct 2019 15:40 [c940bca]

can anyone give me a suggestion for how to solve this problem?

[latios]

I have also been wondering why Dancer/Bard songs aren't showing skill effects. I'm looking through the commit to see if I can spot anything that might have caused it.

@CyberDevil Are you able to confirm that the Dancer/Bard skills work again when you deploy the previous commit 850904a?

 

@CyberDevil Ah, it seems like there is meant to be new skill animations for Bard/Dancer songs/dances; as a part of this update: https://www.divine-pride.net/forum/index.php?/topic/3453-kro-mass-skills-balance-1st-2nd-and-transcendent-classes-skills/

Spoiler

I'd imagine you can revert the changes by removing the #ifndef and #endif statements in skill.cpp.

Spoiler

Plus add the units back into each song/dance in db/re/skill_db.yml

Spoiler

 

[kodkodkub]

On 4/25/2020 at 9:41 PM, CyberDevil said:

can anyone give me a suggestion for how to solve this problem?

it's not really a problem
1. Bard/Dancer most of their skills change range from around caster to the whole of caster's screen
2. from 1. that's the reason why effect removed actually it still have effect but it's using 3rd class aura effect which need newer diff client like 2019++
3. from 2. rAthena still not support newer client at this moment

Hope this's the answer you want to know

[CyberDevil]

Thank you guys, now everything is clearer... I will wait for rathena to be updated to support newer clients... thanks again for the very useful information. +1 an both!

[Agriias]

On 4/28/2020 at 5:45 AM, CyberDevil said:

Thank you guys, now everything is clearer... I will wait for rathena to be updated to support newer clients... thanks again for the very useful information. +1 an both!

eu estou com esse problema tambem as skills nao estao funcionando.