Parry Modification

[Armony]

 

Hi, rA today i have a little mistake about the parry, I've modified this skill allowing use with One-hand with Linked State everything i'ts working fine until i switch any equipment.

see below the behavior

rA version : 9389b

//skill_check_condition_castbegin

if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
		(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
  
  
  
  //skill_check_condition_castend
  if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
	(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
		clif_skill_fail(sd,skill_id,USESKILL_FAIL_THIS_WEAPON,0);
		return false;
	}

Edited March 6, 2020 by Armony

[Scylla]

What i did:

skill_db.yml:

Find LK_PARRYING and on Weapon do this:

      Weapon:
        1hSword: true
        2hSword: true

 

skill.cpp:

Find:

	if( require.ammo ) { //Skill requires stuff equipped in the ammo slot.
		uint8 extra_ammo = 0;

And then add this above it:

	if(skill_id == LK_PARRYING && !(sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT) && sd->weapontype1 == W_1HSWORD){
		clif_skill_fail(sd,skill_id, USESKILL_FAIL_THIS_WEAPON, 0);
		return false;
	}

This check will prevent parrying from being casted w/ 1-handed sword unless when you're in soul link status . (since we allowed to cast parry w/ 1 handed sword naturally even w/o soul link via skill_db)

[Bringer]

24 minutes ago, Armony said:

 

Hi, rA today i have a little mistake about the parry, I've modified this skill allowing use with One-hand with Linked State everything i'ts working fine until i switch any equipment.

see below the behavior

rA version : 9389b

//skill_check_condition_castbegin

if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
		(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
  
  
  
  //skill_check_condition_castend
  if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
	(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
		clif_skill_fail(sd,skill_id,USESKILL_FAIL_THIS_WEAPON,0);
		return false;
	}

check this

https://rathena.org/board/topic/116983-working-lk-soul-link-mod/?do=findComment&comment=351721

[Armony]

On 3/6/2020 at 12:30 PM, Bringer said:

check this

https://rathena.org/board/topic/116983-working-lk-soul-link-mod/?do=findComment&comment=351721

i actually taken the source from this link

anyone could help me? 

[Katakuri]

On 3/6/2020 at 12:05 PM, Armony said:

 

Hi, rA today i have a little mistake about the parry, I've modified this skill allowing use with One-hand with Linked State everything i'ts working fine until i switch any equipment.

see below the behavior

rA version : 9389b

//skill_check_condition_castbegin

if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
		(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
  
  
  
  //skill_check_condition_castend
  if (require.weapon && !(pc_check_weapontype(sd, require.weapon) ||
	(skill_id == LK_PARRYING && sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_KNIGHT && sd->weapontype1 == W_1HSWORD))) {
		clif_skill_fail(sd,skill_id,USESKILL_FAIL_THIS_WEAPON,0);
		return false;
	}

same problem produce anyone got a fix for this?