Help Sound Of Destruction Bug Minstrel/Wanderer

[pueblodefairy]

Hello, Can anyone help me with this bug, Minstrel/Wandy Sound of Destruction show effects but their damage/effect is missing, how can i fix it? Thanks a lot for help. I followed many guides but were not clear, I would like to fix it like their respective effect or add it damage like a damage skill.                                                                                                        

Edited April 7, 2019 by pueblodefairy

[Sakurada]

Ok does this skill normally deal damage do monsters? 

 

it looks like it only deals damage to those under the song statuses

				if( tsc && tsc->count && ( tsc->data[SC_SWING] || tsc->data[SC_SYMPHONY_LOVE] || tsc->data[SC_MOONLIT_SERENADE] ||
						tsc->data[SC_RUSH_WINDMILL] || tsc->data[SC_ECHOSONG] || tsc->data[SC_HARMONIZE] ||
						tsc->data[SC_SIREN] || tsc->data[SC_DEEP_SLEEP] || tsc->data[SC_SIRCLEOFNATURE] ||
						tsc->data[SC_GLOOMYDAY] || tsc->data[SC_SONG_OF_MANA] ||
						tsc->data[SC_DANCE_WITH_WUG] || tsc->data[SC_SATURDAY_NIGHT_FEVER] || tsc->data[SC_LERADS_DEW] ||
						tsc->data[SC_MELODYOFSINK] || tsc->data[SC_BEYOND_OF_WARCRY] || tsc->data[SC_UNLIMITED_HUMMING_VOICE] ) &&
						rnd()%100 < 4 * skill_lv + 2 * (sd ? pc->checkskill(sd,WM_LESSON) : 10) + 10 * battle->calc_chorusbonus(sd)) {
					skill->attack(BF_MISC,src,src,bl,skill_id,skill_lv,tick,flag);

but if you want real damage : 

thats because it it doesnt have a bf_attack... if you look at great echo it uses the same aoe... but it has a bf_weapon...

but if you want that instead just do this

in your skill.c 

		case WM_GREAT_ECHO:
		case GN_SLINGITEM_RANGEMELEEATK:
		case KO_SETSUDAN:
		case GC_DARKCROW:
		case NPC_CONRAY:
		case LG_OVERBRAND_BRANDISH:
		case PA_PRESSURE:
		case LG_OVERBRAND:
		case KN_LIGHTNINGSWING:
		case SJ_FLASHKICK:
			skill->attack(BF_WEAPON,src,src,bl,skill_id,skill_lv,tick,flag);
		break;

just add WM_SOUND_OF_DESTRUCTION under great echo or wherever...

you would have to change the damage formula a bit too just copy great echo..

 

or you can delete this part in your skill.c

case WM_SOUND_OF_DESTRUCTION:
		if( tsc && ( tsc->data[SC_SWINGDANCE] || tsc->data[SC_SYMPHONYOFLOVER] || tsc->data[SC_MOONLITSERENADE] || 
		tsc->data[SC_RUSHWINDMILL] || tsc->data[SC_ECHOSONG] || tsc->data[SC_HARMONIZE] || 
		tsc->data[SC_VOICEOFSIREN] || tsc->data[SC_DEEPSLEEP] || tsc->data[SC_SIRCLEOFNATURE] || 
		tsc->data[SC_GLOOMYDAY] || tsc->data[SC_GLOOMYDAY_SK] || tsc->data[SC_SONGOFMANA] || 
		tsc->data[SC_DANCEWITHWUG] || tsc->data[SC_SATURDAYNIGHTFEVER] || tsc->data[SC_LERADSDEW] || 
		tsc->data[SC_MELODYOFSINK] || tsc->data[SC_BEYONDOFWARCRY] || tsc->data[SC_UNLIMITEDHUMMINGVOICE] ) && 
		rnd()%100 < 4 * skill_lv + 2 * ((sd) ? pc_checkskill(sd, WM_LESSON) : skill_get_max(WM_LESSON)) + 10 * battle_calc_chorusbonus(sd)) {
			status_change_start(src, bl, SC_STUN, 10000, skill_lv, 0, 0, 0, skill_get_time(skill_id,skill_lv), SCSTART_NOTICKDEF);
			status_change_end(bl, SC_DANCING, INVALID_TIMER);
			status_change_end(bl, SC_RICHMANKIM, INVALID_TIMER);
			status_change_end(bl, SC_ETERNALCHAOS, INVALID_TIMER);
			status_change_end(bl, SC_DRUMBATTLE, INVALID_TIMER);
			status_change_end(bl, SC_NIBELUNGEN, INVALID_TIMER);
			status_change_end(bl, SC_INTOABYSS, INVALID_TIMER);
			status_change_end(bl, SC_SIEGFRIED, INVALID_TIMER);
			status_change_end(bl, SC_WHISTLE, INVALID_TIMER);
			status_change_end(bl, SC_ASSNCROS, INVALID_TIMER);
			status_change_end(bl, SC_POEMBRAGI, INVALID_TIMER);
			status_change_end(bl, SC_APPLEIDUN, INVALID_TIMER);
			status_change_end(bl, SC_HUMMING, INVALID_TIMER);
			status_change_end(bl, SC_FORTUNE, INVALID_TIMER);
			status_change_end(bl, SC_SERVICE4U, INVALID_TIMER);
			status_change_end(bl, SC_LONGING, INVALID_TIMER);
			status_change_end(bl, SC_SWINGDANCE, INVALID_TIMER);
			status_change_end(bl, SC_SYMPHONYOFLOVER, INVALID_TIMER);
			status_change_end(bl, SC_MOONLITSERENADE, INVALID_TIMER);
			status_change_end(bl, SC_RUSHWINDMILL, INVALID_TIMER);
			status_change_end(bl, SC_ECHOSONG, INVALID_TIMER);
			status_change_end(bl, SC_HARMONIZE, INVALID_TIMER);
			status_change_end(bl, SC_WINKCHARM, INVALID_TIMER);
			status_change_end(bl, SC_SONGOFMANA, INVALID_TIMER);
			status_change_end(bl, SC_DANCEWITHWUG, INVALID_TIMER);
			status_change_end(bl, SC_LERADSDEW, INVALID_TIMER);
			status_change_end(bl, SC_MELODYOFSINK, INVALID_TIMER);
			status_change_end(bl, SC_BEYONDOFWARCRY, INVALID_TIMER);
			status_change_end(bl, SC_UNLIMITEDHUMMINGVOICE, INVALID_TIMER);
		}
		break;

and just add WM_SOUND_OF_DESTRUCTION to 

		case RK_SONICWAVE:
		case AM_HARVEST:
		case GN_HELLS_PLANT_ATK:
#ifdef RENEWAL
		case ASC_BREAKER:
#endif
			skill->attack(BF_MISC,src,src,bl,skill_id,skill_lv,tick,flag);
			break;

 

 

haha

Edited April 7, 2019 by AndyTheGoblin

[pueblodefairy]

I followed your guide and doest work. Always show the same  damage error                                                                                                 

[pueblodefairy]

2 hours ago, AndyTheGoblin said:

 

Do you want it just to be an AoE skill that deals damage? Forget about all the song stuff and just make it damage?

 

Exactly, you got the point, this is exactly what i am looking. Same visual effect but dealing damage like a Sharp Shooting. Thanks for your help

Edited April 7, 2019 by pueblodefairy

[Sakurada]

19 hours ago, pueblodefairy said:

Exactly, you got the point, this is exactly what i am looking. Same visual effect but dealing damage like a Sharp Shooting. Thanks for your help

I made this video for you, its simple just go over my first post and watch it

btw ctrl + f for the search window

 

 

What do you want it to also deal damage in a straight line ? lol i didnt add that to the video but 

go into skill.c

find this chunk

case SN_SHARPSHOOTING:
	case MA_SHARPSHOOTING:
	case NJ_KAMAITACHI:
	case NPC_DARKPIERCING:
	case NPC_ACIDBREATH:
	case NPC_DARKNESSBREATH:
	case NPC_FIREBREATH:
	case NPC_ICEBREATH:
	case NPC_THUNDERBREATH:
		skill_area_temp[1] = bl->id;
		if (battle_config.skill_eightpath_algorithm) {
			//Use official AoE algorithm
			if (!(map_foreachindir(skill_attack_area, src->m, src->x, src->y, bl->x, bl->y,
			   skill_get_splash(skill_id, skill_lv), skill_get_maxcount(skill_id, skill_lv), 0, splash_target(src),
			   skill_get_type(skill_id), src, src, skill_id, skill_lv, tick, flag, BCT_ENEMY))) {
				//These skills hit at least the target if the AoE doesn't hit
				skill_attack(skill_get_type(skill_id), src, src, bl, skill_id, skill_lv, tick, flag);
			}
		} else {
			map_foreachinpath(skill_attack_area, src->m, src->x, src->y, bl->x, bl->y,
				skill_get_splash(skill_id, skill_lv), skill_get_maxcount(skill_id, skill_lv), splash_target(src),
				skill_get_type(skill_id), src, src, skill_id, skill_lv, tick, flag, BCT_ENEMY);
		}
		if (skill_id == SN_SHARPSHOOTING)
			status_change_end(src, SC_CAMOUFLAGE, INVALID_TIMER);
		break;

just add WM_SOUND_OF_DESTRUCTION under Sharpshooting, and then delete everything else related to WM_SOUND_OF_DESTRUCTION..

 

 

someone could probably make some merge thing, itd be way easier but i dont know how to do that

[pueblodefairy]

Thanks a lot, excellent video, i am working on that. i still getting the same error even following every step, but it is ok, maybe it can´t be fix in my server. I really appreciate your help to solve this problem.                                                                                          

[Sakurada]

you have 2 different skilldbs, one under pre re and another under renewal, make sure you edit the right one, also you could try replacing your files in the src>map and db>re>skill_db 

battle.cpp skill.cpp skill_db.txt

[pueblodefairy]

Thanks a lot, but same results. I will delete the skill. Thanks a lot for you hard work and time.