Sharp Shooting Bug?

[Anta]

Hello guys, i'm newbie in the community, so i don't know if my post is in the correct section.

Yesterday i implemented multi-hit critical damage, then i started to check some skills, in fact everything Works fine, but i think that maybe there's a bug with Sharp Shooting.

It's supposed that Sharp Shooting Will deal a critical damage if you have a high critical rate, but the skill doesn't do something like that.

I tested in my server, and also i tried in a local server with the last emulator update, because i believed that maybe the bug appears when i applied the multi-hit critical patch, but it doesn't.

First this's on my server:

And this's on the local server with the last emulator update:

 

Like you can see, Sharp Shooting can't do a critical damage, and because of that anything that increases critical damage like the paper card, temporal boots LUK, or anything else doesn't boost the damage. 

Excuse me for my bad english.

Forget it. i already solved it.

Edited March 20, 2019 by Anta

[Tiki59]

+1 I have the same bug, the answer interests me.

Edit: idem for the skill cart canon... 

Edited September 15, 2019 by Tiki59

[Ice Bear]

On 3/19/2019 at 9:49 AM, Anta said:

Hello guys, i'm newbie in the community, so i don't know if my post is in the correct section.

Yesterday i implemented multi-hit critical damage, then i started to check some skills, in fact everything Works fine, but i think that maybe there's a bug with Sharp Shooting.

It's supposed that Sharp Shooting Will deal a critical damage if you have a high critical rate, but the skill doesn't do something like that.

I tested in my server, and also i tried in a local server with the last emulator update, because i believed that maybe the bug appears when i applied the multi-hit critical patch, but it doesn't.

First this's on my server:

And this's on the local server with the last emulator update:

 

Like you can see, Sharp Shooting can't do a critical damage, and because of that anything that increases critical damage like the paper card, temporal boots LUK, or anything else doesn't boost the damage. 

Excuse me for my bad english.

Forget it. i already solved it.

how do you solve it.

???

[sader1992]

7 hours ago, Ice Bear said:

how do you solve it.

???

https://github.com/rathena/rathena/pull/4454

[Ice Bear]

1 hour ago, sader1992 said:

https://github.com/rathena/rathena/pull/4454

sorry i am kind of confused but anyway i have fix it its just the crit animation not showing thank you @sader1992 :3

 

[sader1992]

47 minutes ago, Ice Bear said:

sorry i am kind of confused but anyway i have fix it its just the crit animation not showing thank you @sader1992 :3

 

as far as i know , skills have their own animation not like normal attack or multi hit attack

Edited December 23, 2019 by sader1992

[Ice Bear]

1 hour ago, sader1992 said:

as far as i know , skills have their own animation not like normal attack or multi hit attack

yes i found a way to add the crit same with ground drift? forgot the other skill but it works

[Subzero]

On 3/19/2019 at 9:49 AM, Anta said:

Hello guys, i'm newbie in the community, so i don't know if my post is in the correct section.

Yesterday i implemented multi-hit critical damage, then i started to check some skills, in fact everything Works fine, but i think that maybe there's a bug with Sharp Shooting.

It's supposed that Sharp Shooting Will deal a critical damage if you have a high critical rate, but the skill doesn't do something like that.

I tested in my server, and also i tried in a local server with the last emulator update, because i believed that maybe the bug appears when i applied the multi-hit critical patch, but it doesn't.

First this's on my server:

And this's on the local server with the last emulator update:

 

Like you can see, Sharp Shooting can't do a critical damage, and because of that anything that increases critical damage like the paper card, temporal boots LUK, or anything else doesn't boost the damage. 

Excuse me for my bad english.

Forget it. i already solved it.

can u share which part need change?

please need it