Change Gospel double SP buff

[Arthas]

As the title says, I need gospel to give its bonus of sp x2 to the whole thing, not just the base SP as it does currently (at least that's what I understand rathena gospel does), I need it to also double equipment/cards, Service for You, food and whatever that adds SP.

(I think is the rathena emulator the one that only doubles vase sp, because in every other it doubles the whole thing, which is the kind of gospel I'm used to)

I know this part of the skill.cpp scripts gospel

case 4: // MaxSP +100%
	sc_start(ss, bl, SC_INCMSPRATE, 100, 100, time);
	if (tsd) clif_gospel_info(tsd, 0x18);
	break;

 

and then again in status.cpp

if (sc) {
	if(sc->data[SC_INCMSPRATE])
	bonus += sc->data[SC_INCMSPRATE]->val1;

 

but I'm not really sure how the math formula calculates the sp getting doubled, so if anyone can tell me what to do, I'd be thankful.

 

 

[lllaaazzz]

Sorry dude, i would help you out but im on Hercules Emulator, you should consider switching, and then just hang around here because they wont help you either. 

 

I just cant test what i post myself, but its usually pretty reusable. . . like i said go grab a bstatus->sp thing and try throwing it in your formula

 

Edited February 7, 2019 by lllaaazzz

[utofaery]

3 hours ago, lllaaazzz said:

Sorry dude, i would help you out but im on Hercules Emulator, you should consider switching, and then just hang around here because they wont help you either. 

Same same here lol.

 

4 hours ago, Arthas said:

case 4: // MaxSP +100%
	sc_start(ss, bl, SC_INCMSPRATE, 100, 100, time);
	if (tsd) clif_gospel_info(tsd, 0x18);
	break;

try 

sc_start(ss, bl, SC_INCMSPRATE, 100, 100, time);

to 

sc_start(ss, bl, SC_INCMSPRATE, 200, 200, time);

[Arthas]

try 

sc_start(ss, bl, SC_INCMSPRATE, 100, 100, time);

to 

sc_start(ss, bl, SC_INCMSPRATE, 200, 200, time);

 

Wouldn't that just give me the base sp x200%?? 

[AnnieRuru]

prontera,155,185,5	script	kjsdhfskfh	1_F_MARIA,{
	sc_start SC_INCMSPRATE,1000,100;
	end;
}

tested on rAthena, this increase my maximum SP by 100% for 1 second

no idea why you say it gives base SP ... I tested with a swordsman equip whole body with wilow_card

swordsman lv50, 111 SP -> click on NPC = 222 SP
boosted with lots of wilow_card, 1141 SP -> 2282 SP
boosted with service for you, 1975 SP -> 3386 SP ... ok this one questionable (58%) probably because the shitty way how we add the value

 

btw nice to know some members still using hercules, thought that forum dead
think should go back hercules support more and less on rathena forum ...

[lllaaazzz]

2 hours ago, utofaery said:

Same same here lol.

 

try 

sc_start(ss, bl, SC_INCMSPRATE, 100, 100, time);

to 

sc_start(ss, bl, SC_INCMSPRATE, 200, 200, time);

I was thinking of you when i posted this

[utofaery]

47 minutes ago, AnnieRuru said:

btw nice to know some members still using hercules, thought that forum dead
think should go back hercules support more and less on rathena forum ...

Well there it's like niflheim 

here is like prontera...

 

And there you need to be self researching, self sufficient, self doing a lot of things.

rathena is like half spoon half of anything else.

Edited February 8, 2019 by utofaery

[Arthas]

This part is right.

2 hours ago, AnnieRuru said:

swordsman lv50, 111 SP -> click on NPC = 222 SP
boosted with lots of wilow_card, 1141 SP -> 2282 SP

but then when you use Service for You that is a % addition and not a plain + 80 like the willow card (that goes directly to the base sp)

then you get the problem

2 hours ago, AnnieRuru said:

boosted with service for you, 1975 SP -> 3386 SP ... ok this one questionable (58%)

and 1975 x2 is not 3386, it should be 3950, that's the part getting me frustrated because this is the first time gospel SP bonus isn't giving me the x2 sp I always had before.

[AnnieRuru]

just forget it,
like I said, the method that add value, multiply, subtract, multiply again ... all developers has been do like this since ancient time eathena
the addition/subtraction and multiply/division should supposedly split into 2 different function
we put all the formula into 1 single function, that's why produce this kind of result

this *bug* exist on all *athena emulator, hercules also affected
that's why malufett wish to redesign this system, but he never complete it

Edited February 8, 2019 by AnnieRuru