Long range reduce magic damage

[playgron]

Hello guys I need help with my long range reduce card ( horn , alligator , etc ) why it also effects on magic ? it reduces on magic , im using pre renewal latest rathena , can someone help me to fix this ? thanks

 

I want any long range reduce attack not reduce magic attack ( like storm gust , etc )

[Vykimo]

Yes,  it should work now.

Explaination :

#ifndef RENEWAL
				//It was discovered that ranged defense also counts vs magic! [Skotlex]
				if( flag&BF_SHORT )
					cardfix = cardfix * (100 - tsd->bonus.near_attack_def_rate) / 100;
				else
					cardfix = cardfix * (100 - tsd->bonus.long_attack_def_rate) / 100;
#endif

as you can see, long_attack_def_rate is only taken in account in magic atk when RENEWAL is set.

If you want to be sure, you can delete this all part shown above.

 

[playgron]

bump anyone ? im using pre-renewal.

[Vykimo]

Apparently, it was discovered by Skotlex that ranged defense also counts vs magic ! for renewal at least… (it's written in sources)

So can you first verify that Renewal is unset in config/renewal.hpp (#define PRERE must be uncommented).

[playgron]

1 hour ago, Vykimo said:

Apparently, it was discovered by Skotlex that ranged defense also counts vs magic ! for renewal at least… (it's written in sources)

So can you first verify that Renewal is unset in config/renewal.hpp (#define PRERE must be uncommented).

I tried still not working , do I have to comment this ? (#ifndef PRERE)

Edit: I tried to comment #ifndef PRERE and got error so it's still not working

Edited October 25, 2018 by playgron

[Vykimo]

You only have to do this in config/renewal.hpp :

#define PRERE

It should be enough; If it's not.

comment this too :

//#define RENEWAL

 

Edited October 25, 2018 by Vykimo

[playgron]

6 minutes ago, Vykimo said:

You only have to do this in config/renewal.hpp :

#define PRERE

It should be enough; If it's not.

comment this too :

//#define RENEWAL

 

I did comment the renewal since the start.

 

// Copyright (c) rAthena Dev Teams - Licensed under GNU GPL
// For more information, see LICENCE in the main folder

#ifndef CONFIG_RENEWAL_HPP
#define CONFIG_RENEWAL_HPP

//quick option to disable all renewal option, used by ./configure
#define PRERE
#ifndef PRERE
/**
 * rAthena configuration file (http://rathena.org)
 * For detailed guidance on these check http://rathena.org/wiki/SRC/config/
 **/


/**
 * @INFO: This file holds general-purpose renewal settings, for class-specific ones check /src/config/classes folder
 **/

/// Game renewal server mode
/// (disable by commenting the line)
///
/// Leave this line to enable renewal specific support such as renewal formulas
//#define RENEWAL

/// Renewal cast time
/// (disable by commenting the line)
///
/// Leave this line to enable renewal casting time algorithms and enable fixed cast bonuses.
/// See also default_fixed_castrate in conf/battle/skill.conf for default fixed cast time (default is 20%).
/// Cast time is altered be 2 portion, Variable Cast Time (VCT) and Fixed Cast Time (FCT).
/// By default FCT is 20% of VCT (some skills aren't)
/// - VCT is decreased by DEX * 2 + INT.
/// - FCT is NOT reduced by stats, reduced by equips or buffs.
/// Example:
///  On a skill whos cast time is 10s, only 8s may be reduced. the other 2s are part of a FCT
//#define RENEWAL_CAST

/// Renewal drop rate algorithms
/// (disable by commenting the line)
///
/// Leave this line to enable renewal item drop rate algorithms
/// While enabled a special modified based on the difference between the player and monster level is applied
/// Based on the http://irowiki.org/wiki/Drop_System#Level_Factor table
//#define RENEWAL_DROP

/// Renewal exp rate algorithms
/// (disable by commenting the line)
///
/// Leave this line to enable renewal item exp rate algorithms
/// While enabled a special modified based on the difference between the player and monster level is applied
//#define RENEWAL_EXP

/// Renewal level modifier on damage
/// (disable by commenting the line)
///
// Leave this line to enable renewal base level modifier on skill damage (selected skills only)
//#define RENEWAL_LVDMG

/// Renewal ASPD [malufett]
/// (disable by commenting the line)
///
/// Leave this line to enable renewal ASPD
/// - shield penalty is applied
/// - AGI has a greater factor in ASPD increase
/// - there is a change in how skills/items give ASPD
/// - some skill/item ASPD bonuses won't stack
//#define RENEWAL_ASPD

/// Renewal stat calculations
/// (disable by commenting the line)
///
/// Leave this line to enable renewal calculation for increasing status/parameter points
//#define RENEWAL_STAT

#endif

#endif /* CONFIG_RENEWAL_HPP */

 

[playgron]

12 minutes ago, Vykimo said:

Yes,  it should work now.

Explaination :

#ifndef RENEWAL
				//It was discovered that ranged defense also counts vs magic! [Skotlex]
				if( flag&BF_SHORT )
					cardfix = cardfix * (100 - tsd->bonus.near_attack_def_rate) / 100;
				else
					cardfix = cardfix * (100 - tsd->bonus.long_attack_def_rate) / 100;
#endif

as you can see, long_attack_def_rate is only taken in account in magic atk when RENEWAL is set.

If you want to be sure, you can delete this all part shown above.

 

finally! I removed those and it worked! thank you so much