Need Help my collector item script

hendra814 · September 27, 2017

Need help, everytime player report to npc

item failed to be deleted and player not given the reward too.

here the scipt

Spoiler

prontera,164,219,4	script	Collector	116,{

oninit:
set .itemrew,0;
set .itemrewq,0;
set .itemcoll,0;
set .itemquan,0;

if (getgmlevel()>60) goto admin;
if (.help == 1) goto reward;


mes "Welcome "+strcharinfo(0)+",";
mes "I'm Collector rune midgard item";
switch(select("What item do you collect:Ok, nice to meet you")) {
	case 1:
	next;
	if (.itemcoll == 0) { mes "Sorry, I'm not collecting item for now."; end;}
	mes "please collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
	mes "and i will reward you "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
	set .help,1;
	end;
	
	case 2:
	next;
	mes "Okay, see you later.";
	end;
}

reward:
	set .amounts, countitem(.itemcoll);
	if ( .amounts!= .itemquan) {mes "the quantity item not enough.";}
	mes "Thanks for your help";
	mes "here my reward for you.";
	delitem .itemcoll,.itemquan;
	getitem .itemrew,itemrewq;
	set help,0;
	end;
	
admin:
mes "Welcome "+strcharinfo(0)+",";
mes "Please input what item for player to collect.";
next;
input .itemcoll;
set .itemcoll,.itemcoll;
next;
mes "Please input how many item to collect.";
next;
input .itemquan;
set .itemquan,.itemquan;
next;
mes "Please input what the reward item.";
input .itemrew;
set .itemrew,.itemrew;
next;
mes "Please input how many item reward.";
input .itemrewq;
set .itemrewq,.itemrewq;
next;
mes "Are you done?";
switch(select("Yes:No.")) {
	case 1:
	mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
	mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
	end;
	
	case 2:
	mes "Okay, to re entry, please start form the begining.";
	end;
}
}

and here the error

image.png.db1f1d8ab432c6fd55793232a98e6db8.png

and is it posible to make this npc running for x period, like 1 day or 1 week

Thanks for any help

Edited September 27, 2017 by hendra814

sader1992 · September 27, 2017

at the first script

getitem .itemrew,itemrewq;

it's .itemrewq not itemrewq




prontera,164,219,4	script	Collector	116,{
	if (getgmlevel()>60) goto admin;
	if (.help == 1) goto reward;
	mes "Welcome "+strcharinfo(0)+",";
	mes "I'm Collector rune midgard item";
	switch(select("What item do you collect:Ok, nice to meet you")) {
		case 1:
		next;
		if (.itemcoll == 0) { mes "Sorry, I'm not collecting item for now."; end;}
		mes "please collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "and i will reward you "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		set .help,1;
		end;
		
		case 2:
		next;
		mes "Okay, see you later.";
		end;
	}
	
reward:
	set .amounts, countitem(.itemcoll);
	if ( .amounts <= .itemquan) {mes "the quantity item not enough.";}
	mes "Thanks for your help";
	mes "here my reward for you.";
	delitem .itemcoll,.itemquan;
	getitem .itemrew,.itemrewq;
	set help,0;
end;
	
admin:
	mes "Welcome "+strcharinfo(0)+",";
	mes "Please input what item for player to collect.";
	next;
	input .itemcoll;
	//set .itemcoll,.itemcoll;
	next;
	mes "Please input how many item to collect.";
	next;
	input .itemquan;
	//set .itemquan,.itemquan;
	next;
	mes "Please input what the reward item.";
	input .itemrew;
	//set .itemrew,.itemrew;
	next;
	mes "Please input how many item reward.";
	input .itemrewq;
	//set .itemrewq,.itemrewq;
	next;
	mes "Are you done?";
	switch(select("Yes:No.")) {
		case 1:
		mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		end;
		
		case 2:
		mes "Okay, to re entry, please start form the begining.";
		end;
	}
end;

OnInit:
	set .itemrew,0;
	set .itemrewq,0;
	set .itemcoll,0;
	set .itemquan,0;
end;
}

Edited September 27, 2017 by sader1992

crazyarashi · September 27, 2017

set [email protected], countitem(.itemcoll);
if ( [email protected]!= .itemquan) {mes "the quantity item not enough.";}
//
input [email protected]; // changed to npc variable
set .itemcoll,[email protected];
next;
input [email protected];
set .itemquan,[email protected];
next;
mes "Please input what the reward item.";
input [email protected];
set .itemrew,[email protected];
next;
mes "Please input how many item reward.";
input [email protected];
set .itemrewq,[email protected];

OnInit: //For dummy data
	set .itemcoll,771; //ID Maybe?
	set .itemquan,1;
	set .itemrew,1;
	set .itemrewq,2;

Edited September 27, 2017 by crazyarashi

hendra814 · September 27, 2017

1 hour ago, crazyarashi said:

set [email protected], countitem(.itemcoll);
if ( [email protected]!= .itemquan) {mes "the quantity item not enough.";}
//
input [email protected]; // changed to npc variable
set .itemcoll,[email protected];
next;
input [email protected];
set .itemquan,[email protected];
next;
mes "Please input what the reward item.";
input [email protected];
set .itemrew,[email protected];
next;
mes "Please input how many item reward.";
input [email protected];
set .itemrewq,[email protected];

OnInit: //For dummy data
	set .itemcoll,771; //ID Maybe?
	set .itemquan,1;
	set .itemrew,1;
	set .itemrewq,2;

new problem can't countitem from variable .itemcoll

in doc_script countitem script only for item id or item name.

any idea to solve thie problem?

Spoiler

prontera,164,219,4	script	Collector	116,{

set .amounts, countitem(".itemcoll");

if (getgmlevel()>60) goto admin;
if (.help == 1) goto reward;

mes "Welcome "+strcharinfo(0)+",";
mes "I'm Collector rune midgard item";
switch(select("What item do you collect:Ok, nice to meet you")) {
	case 1:
	next;
	if (.itemcoll == 0) { mes "Sorry, I'm not collecting item for now."; end;}
	mes "please collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
	mes "and i will reward you "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
	set .help,1;
	end;
	
	case 2:
	next;
	mes "Okay, see you later.";
	end;
}

reward:
	if ( .amounts != .itemquan) {mes "the quantity item not enough."; end;}
	mes "Thanks for your help";
	mes "here my reward for you.";
	delitem .itemcoll,.itemquan;
	getitem .itemrew,itemrewq;
	set help,0;
	end;
	
admin:
mes "Welcome "+strcharinfo(0)+",";
mes "Please input what item for player to collect.";
next;
input ivalue;
set .itemcoll, ivalue;
next;
mes "Please input how many item to collect.";
next;
input ivalueq;
set .itemquan, ivalueq;
next;
mes "Please input what the reward item.";
input rvalue;
set .itemrew, rvalue;
next;
mes "Please input how many item reward.";
input rvalueq;
set .itemrewq, rvalueq;
next;
mes "Are you done?";
switch(select("Yes:No.")) {
	case 1:
	mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
	mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
	end;
	
	case 2:
	mes "Okay, to re entry, please start form the begining.";
	end;
}
oninit:
set .itemcoll,7539; //item to collect
set .itemquan,1;	//item collect quantity
set .itemrew,7539;	//item reward
set .itemrewq,10;	//item reward quantity
}

Edited September 27, 2017 by hendra814

hendra814 · September 27, 2017

5 minutes ago, sader1992 said:
at the first script
getitem .itemrew,itemrewq;
it's .itemrewq not itemrewq

@sader1992

Thanks for this.

hendra814 · September 27, 2017

6 hours ago, sader1992 said:

at the first script

getitem .itemrew,itemrewq;

it's .itemrewq not itemrewq




prontera,164,219,4	script	Collector	116,{
	if (getgmlevel()>60) goto admin;
	if (.help == 1) goto reward;
	mes "Welcome "+strcharinfo(0)+",";
	mes "I'm Collector rune midgard item";
	switch(select("What item do you collect:Ok, nice to meet you")) {
		case 1:
		next;
		if (.itemcoll == 0) { mes "Sorry, I'm not collecting item for now."; end;}
		mes "please collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "and i will reward you "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		set .help,1;
		end;
		
		case 2:
		next;
		mes "Okay, see you later.";
		end;
	}
	
reward:
	set .amounts, countitem(.itemcoll);
	if ( .amounts <= .itemquan) {mes "the quantity item not enough.";}
	mes "Thanks for your help";
	mes "here my reward for you.";
	delitem .itemcoll,.itemquan;
	getitem .itemrew,.itemrewq;
	set help,0;
end;
	
admin:
	mes "Welcome "+strcharinfo(0)+",";
	mes "Please input what item for player to collect.";
	next;
	input .itemcoll;
	//set .itemcoll,.itemcoll;
	next;
	mes "Please input how many item to collect.";
	next;
	input .itemquan;
	//set .itemquan,.itemquan;
	next;
	mes "Please input what the reward item.";
	input .itemrew;
	//set .itemrew,.itemrew;
	next;
	mes "Please input how many item reward.";
	input .itemrewq;
	//set .itemrewq,.itemrewq;
	next;
	mes "Are you done?";
	switch(select("Yes:No.")) {
		case 1:
		mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		end;
		
		case 2:
		mes "Okay, to re entry, please start form the begining.";
		end;
	}
end;

OnInit:
	set .itemrew,0;
	set .itemrewq,0;
	set .itemcoll,0;
	set .itemquan,0;
end;
}

Need small fixing

set help,0; fix into set .help,0;

but it's okay. over all the script run like i want.

Thank you very much Sader.

sader1992 · September 27, 2017

2 hours ago, hendra814 said:

set help,0; fix into set .help,0;

you welcome

i would suggest changing .help to help

.help = npc variable << so .help for you is the same .help for every player (if your .help 500 then every player have it 500)

help = char variable << this are unique for each character

hendra814 · September 28, 2017

6 hours ago, sader1992 said:

you welcome

i would suggest changing .help to help

.help = npc variable << so .help for you is the same .help for every player (if your .help 500 then every player have it 500)

help = char variable << this are unique for each character

so i must change all .help into help right?

sader1992 · September 28, 2017

11 minutes ago, hendra814 said:

so i must change all .help into help right?

yes

hendra814 · September 28, 2017

2 hours ago, sader1992 said:

yes

ok, i already change and add some modification

here my lastest script

Spoiler

prontera,164,219,4	script	Collector	116,{
	if (getgmlevel()>60) goto admin;
	if (help == 1) goto reward;
	mes "Welcome "+strcharinfo(0)+",";
	mes "I'm Collector rune midgard item";
	switch(select("What item do you collect:Ok, nice to meet you")) {
		case 1:
		next;
		if (.itemcoll == 0) { mes "Sorry, I'm not collecting item for now."; end;}
		mes "Please collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "and i will reward you "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		mes "Are you could help me to collect the items?";
		switch(select("Ok, I'll help you:Sorry, i couldn't help you")) {
			case 1:
			next;
			mes "Thank you very much";
			mes "I'll waiting for you come again";
			set help,1;
			end;

			case 2:
			next;
			mes "Okay, see you later.";
			end;
		}
		
		case 2:
		next;
		mes "Okay, see you later.";
		end;
	}
	
reward:
	mes "Welcome "+strcharinfo(0)+",";
	mes "are you already collect the items?";
	switch(select("Yes, here the items:Sorry, i want abort the request")) {
		case 1:
		next;
		set .amounts, countitem(.itemcoll);
		if ( .amounts < .itemquan) {mes "the quantity item not enough.";end;}
		mes "Thanks for your help";
		mes "here my reward for you.";
		delitem .itemcoll,.itemquan;
		getitem .itemrew,.itemrewq;
		set help,0;
		end;
		
		case 2:
		mes "Okay, see you later.";
		set help,0;
		end;
	}
	
admin:
	mes "Welcome "+strcharinfo(0)+",";
	mes "Choose what are you want to do";
	switch(select("input item to collect and reward:View summary")) {
		case 1:
		mes "Please input what item for player to collect.";
		next;
		input .itemcoll;
		next;
		mes "Please input how many item to collect.";
		next;
		input .itemquan;
		next;
		mes "Please input what the reward item.";
		input .itemrew;
		next;
		mes "Please input how many item reward.";
		input .itemrewq;
		next;
		mes "Are you done?";
		switch(select("Yes:No.")) {
			case 1:
			next;
			mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
			mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
			end;
			
			case 2:
			mes "Okay, to re entry, please start form the begining.";
			end;
		}

		case 2:
		next;
		mes "Item to collect "+getitemname(.itemcoll)+" for "+.itemquan +" pcs.";
		mes "Item reward "+getitemname(.itemrew)+" for "+.itemrewq +" pcs.";
		end;
	}
end;

OnInit:
	set .itemrew,0;
	set .itemrewq,0;
	set .itemcoll,0;
	set .itemquan,0;
end;
}

Edited September 28, 2017 by hendra814

sader1992 · September 28, 2017

just on line 39

set .amounts, countitem(.itemcoll);
if ( .amounts < .itemquan)

to

if ( countitem(.itemcoll) < .itemquan)

or

set .@amounts, countitem(.itemcoll);
if ( .@amounts < .itemquan)

the first one may do a problem if 2 players speak with the npc at the same time

llchrisll · September 28, 2017

Just a small personal opinion, but I would use for 2 menu options an if(select()) like:

if(select("Yes:No") == 1) {
	//Yes
	} else {
	//No
	}

Better than using an switch, but like I said, personal opinion. 😁

Regards,

Chris

Edited September 28, 2017 by llchrisll

hendra814 · March 2, 2018

On 9/28/2017 at 9:17 PM, sader1992 said:
just on line 39
set .amounts, countitem(.itemcoll);
if ( .amounts < .itemquan) 
to
if ( countitem(.itemcoll) < .itemquan) 
or
set .@amounts, countitem(.itemcoll);
if ( .@amounts < .itemquan) 
the first one may do a problem if 2 players speak with the npc at the same time

Thanks @sader for already change it.

On 9/28/2017 at 9:30 PM, llchrisll said:
Just a small personal opinion, but I would use for 2 menu options an if(select()) like:
if(select("Yes:No") == 1) {
	//Yes
	} else {
	//No
	}
Better than using an switch, but like I said, personal opinion. 😁

Regards,

Chris

ok will try it.

Sign In

Need Help my collector item script

Question

Link to comment

Share on other sites

12 answers to this question

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Recently Browsing 0 members

Important Information