Party Buff No Twitch (on non-casters) [Custom]

[maraskan_user]

This will prevent the twitch animation that all characters in a party show, when the group buffs AL_ANGELUS, PR_MAGNIFICAT, PR_GLORIA or SN_WINDWALK are cast. I always thought it to be very weird that all members would stop walking and show a cast animation when these skills complete, instead of just the caster himself. Uses clif_specialeffect() instead of clif_skill_nodamage() since the latter is hard wired to show the twitch for those skill ids.

File: skill.c
Function: skill_castend_nodamage_id()

Find and change:

    case AL_ANGELUS:
    case PR_MAGNIFICAT:
    case PR_GLORIA:
    case SN_WINDWALK:
    case CASH_BLESSING:
    case CASH_INCAGI:
    case CASH_ASSUMPTIO:
    case WM_FRIGG_SONG:
        if( sd == NULL || sd->status.party_id == 0 || (flag & 1) )
/*new*/     {
/*new*/        if (src->id != bl->id)
/*new*/            {
/*new*/            if (sc_start(src,bl,type,100,skill_lv,skill_get_time(skill_id,skill_lv)))
/*new*/                {
/*new*/                if (skill_id == AL_ANGELUS)
/*new*/                    clif_specialeffect(bl, 41, AREA);
/*new*/                else if (skill_id == PR_MAGNIFICAT)
/*new*/                    clif_specialeffect(bl, 76, AREA);
/*new*/                else if (skill_id == PR_GLORIA)
/*new*/                    clif_specialeffect(bl, 75, AREA);
/*new*/                else if (skill_id == SN_WINDWALK)
/*new*/                    clif_specialeffect(bl, 389, AREA);
/*new*/                }
/*new*/            }
/*new*/        else
                       clif_skill_nodamage(bl, bl, skill_id, skill_lv, sc_start(src,bl,type,100,skill_lv,skill_get_time(skill_id,skill_lv)));
/*new*/     }
        else if( sd )
            party_foreachsamemap(skill_area_sub, sd, skill_get_splash(skill_id, skill_lv), src, skill_id, skill_lv, tick, flag|BCT_PARTY|1, skill_castend_nodamage_id);
        break;

 

Edited January 30, 2017 by Sotto

[zackdreaver]

Is this official behavior?

If so, you should make a PR for this.

[maraskan_user]

The twitch for non-casting party members, though sucky, is official behaviour. This mod diverges from official in that it doesn't stop the party member movement while a priest (or ranger) is applying non-targeted buffs.