Compile warnings after updating to hash d20a7cafc0c32c0d6e2ad67e58f9ba45110d7ac7

[Technoken]

I'm having this compilation warning after updating my git hash from 4e137d3047a9f9d5327212787c9d61a9c811a46c to d20a7cafc0c32c0d6e2ad67e58f9ba45110d7ac7

3>..\src\char\char_mapif.c(1041): warning C4305: 'initializing' : truncation from 'unsigned int' to 'uint16'
3>..\src\char\char_mapif.c(1070): warning C4305: 'initializing' : truncation from 'unsigned int' to 'uint16'
1>  chrif.c
3>  int_mercenary.c
3>  int_party.c
3>  int_pet.c
3>  int_quest.c
3>  int_storage.c
3>  inter.c
1>  clif.c
1>  date.c
1>..\src\map\chrif.c(312): warning C4305: '=' : truncation from 'unsigned int' to 'uint16'

I don't have any src edits in these files(char_mapif.c & chrif.c)

 

It's pointing out to these lines

\src\char\char_mapif.c(1041)

\src\char\char_mapif.c(1070)

\src\map\chrif.c(312)

 

I have no idea what actually causes the warning. Can anyone help me?

 

Thanks!

 

EDIT:

After I started my server this error appears

[Error]: mmo_charstatus size = 75472 is too big to be transmitted. (must be belo
w 0xFFFF)

Edited August 21, 2016 by Technoken

[Technoken]

If you don't want to change the packets, you'll have to make the size of mmo_charstatus to less then 65535 bytes.

 

Currently it's 75472, so you need to shave off about 10000 bytes.

The size of struct s_skill is 8 bytes.

10000/8 is 1250

So lower the MAX_SKILL by at least 1250.

I was thinking why was this warning occurred after I updated. It wasn't there before. I tried to use 1200 on max_skill. Hoping that the mod will still work after this. lol was just about to test it.

 

EDIT/UPDATE:

I solved it by using MAX_SKILL 1200 in mmo.h and it's working fine now.

 

Thanks for those who helped! 

Edited August 22, 2016 by Technoken

[Kakaroto]

I'm having this compilation warning after updating my git hash from 4e137d3047a9f9d5327212787c9d61a9c811a46c to d20a7cafc0c32c0d6e2ad67e58f9ba45110d7ac7

3>..\src\char\char_mapif.c(1041): warning C4305: 'initializing' : truncation from 'unsigned int' to 'uint16'
3>..\src\char\char_mapif.c(1070): warning C4305: 'initializing' : truncation from 'unsigned int' to 'uint16'
1>  chrif.c
3>  int_mercenary.c
3>  int_party.c
3>  int_pet.c
3>  int_quest.c
3>  int_storage.c
3>  inter.c
1>  clif.c
1>  date.c
1>..\src\map\chrif.c(312): warning C4305: '=' : truncation from 'unsigned int' to 'uint16'

I don't have any src edits in these files(char_mapif.c & chrif.c)

 

It's pointing out to these lines

\src\char\char_mapif.c(1041)

\src\char\char_mapif.c(1070)

\src\map\chrif.c(312)

 

I have no idea what actually causes the warning. Can anyone help me?

 

Thanks!

 

I am also having the same problem.

[Technoken]

BUMP! HELP PLEASE! I can't start my server because of this.

[Kakaroto]

Who can help is @Secrets

[Secrets]

Did you make any change to MAX_INVENTORY or MAX_STORAGE?

[Kakaroto]

Did you make any change to MAX_INVENTORY or MAX_STORAGE?

 

 

Nop:

#define MAX_INVENTORY 100 ///Maximum items in player inventory
#define MAX_STORAGE 600 ///Max number of storage slots a player can have, (up to ~850 tested)
#define MAX_GUILD_STORAGE 600 ///Max number of storage slots a guild

[eldivi]

I have the same problem. i want to increase the MAX_STORAGE, MAX_INVENTORY and MAX_CART. plz help us.

[Technoken]

Found out what's causing the problem with me. Because of the mod I applied OnPCUseSkillEvent. It modifies MAX_SKILL from 1200 to 4000 in mmo.h.

I'm still trying to figure out how to fix it.

[nitrous]

If you don't want to change the packets, you'll have to make the size of mmo_charstatus to less then 65510 bytes.

 

Currently it's 75472, so you need to shave off about 10000 bytes.

The size of struct s_skill is 8 bytes.

10000/8 is 1250

So lower the MAX_SKILL by at least 1250.

Edited August 22, 2016 by Nitrous

[Kakaroto]

If you don't want to change the packets, you'll have to make the size of mmo_charstatus to less then 65510 bytes.

 

Currently it's 75472, so you need to shave off about 10000 bytes.

The size of struct s_skill is 8 bytes.

10000/8 is 1250

So lower the MAX_SKILL by at least 1250.

 

 

But I do not modified it in my emulator ...

[Technoken]

But I do not modified it in my emulator ...

 

Maybe you modified something in your mmo.h? try to look for the changes you made in mmo.h

[Kakaroto]

 

But I do not modified it in my emulator ...

 

Maybe you modified something in your mmo.h? try to look for the changes you made in mmo.h

 

 

only that.

#define DEFAULT_WALK_SPEED 120 ///Default walk speed is 150
#define MAX_CHARS 18 /// Default is 9

[eldivi]

'How I make to increase the MAX_STORAGE of 600 to 2000, MAX_INVENTORY OF 100 to 300 and MAX_CART of 100 to 500. I can't compile this. can you help me?

[nitrous]

You can either revert the Random Option commits, rewrite the packets between char and map, or lower your limits.

 

I've started working on a fix, but until then, just revert the Random Option commits.

https://rathena.org/board/topic/107116-packet-size-increase-for-mmo-charstatus/

Edited August 22, 2016 by Nitrous

[eldivi]

Could you upload your files of the scr folder to overwrite on my server and test if going working good? Thanks for you help ^^