December Digest 2015

[nanakiwurtz]

December Digest 2015
The following digest covers the month of December, 2015.

Staff Changes

• None

Development Highlights

• CORE:
  • Added big HP bar support for Boss and Mini-Boss (1f11603), (468bd6)
  • Added missing packets version check (92d617b)
  • Fixed the close button not displaying after canceling a shop transaction (42b7ba9)
  • Fixed Buy and Sell from NPC Shop, Callshop and npcshopattach (0212d44), (8b3b32e), (0c9bd30)
  • Fixed quest objectives being shown by client incorrectly on monster kill (5fc3cbf)
  • Updated the maximum size for packets (f4b42b2), (ba184ab)
  • Removed maximum packet size from configuration (c28c9f6)
  • Increased HP/SP skill requirement variable up to uint32 (bdff641), (2f8699b)
  • Fixed required equipment check needing all equipment given to be equipped rather than just one (27e90f8)
  • Implemented the one-click item identify packet (5fe8145)
  • Fixed Auction system (c75cc2a)
  • Fixed issues Character Deletion Time for the client 2014 or newer (0042fe5), (118fa28)
  • Implemented Vending and Buying Store report packet (01adc9c)
  • Added new Pushcart Decoration packet (71c6896)
  • Implemented the new Feeding Log feature (879ddcc)
  • Fixed a bug with @disguise and @hide command (2f471a1)
  • Fixed memory corrupt issue (4871dab)
  • Added warning when a script is not exist (98c30e6)

• DATABASE:
  • Item Package update (9dafcee)
  • Removed Renewal items from Pre-RE skill requirements for 3rd classes (523cb14)
  • Elemental Control will no longer be removed on map change/Teleport (feb885c)
  • Spore Explosion will now properly give damage to targets (8f4660b)
  • Updated various detection skills pulling out hidden targets (c7ede8d)
  • Adjusted the check for hidden targets for Earth Shaker (4b7301a)
  • Fixed Tiger Cannon not reducing HP when max HP is out of variable bounds (f7f1ec0)
  • Fixed Hesperus Lit and Ray of Genesis Banding check (2e2e1ab)
  • Earth Strain no longer strips enemies that don't receive damage (be3d5fe)
  • Updated Genetic Sling Item effects (89a33a7)
  • Fixed bugs in skill Shadow Form and Body Paint (29306b1)
  • Updated effects for skill Emergency Escape, Chaos, Panic, Cart Cannon, Dragon Breath, Death Bound, Blood Sucker, Magnetic Field, Fire Pillar, Volcanic Ash, Flying Side Kick, Howling of Mandragora, Drum of Battlefield, Hell's Plant (4358504), (66298f3), (aec1b11), (174244b), (3f8b381), (c17b275), (3f8055d), (c0e6fae), (71ffda3), (49f1c43), (9632d2a), (dccf7a3), (f47d4dc)
  • Updated Item DB scripts and locations (b2b37fc), (ee0d256) ,(b53eacd), (d14f75e), (2807be3), (22a9a74)
  • Updated Cash Item DB from idRO (70eb71d)
  • Fixed Item Delay database (9aa8325), (d8830d2)
  • Added WOE:TE items into item_trade.txt (0506fc9)
  • Added missing items into item_buyingstore.txt (19ceb84)

• SCRIPT:
  • Merged Criatura Novice Academy into Master repo (2b5332a)
  • Cleanup redundant usage of `getarg()` in enchan_mal.txt (36d8527), (f5beee17)
  • Fixed a bug in Sapha's Visit quest (d6343fb)
  • Fixed bugs in Sealed Shrine instance (eec8836)

• OTHERS:
  • Stat Reporter is now disabled by default (0ffeec0)
  • Updated script_commands.txt, const.txt and item_bonus.txt (1f47604), (241e10b), (b0e289f), (649acd8)

Statistics

• 9 authors have pushed 84 commits during this period.
• On master, 129 files have changed.
• There have been 17,489 additions and 1,757 deletions.
• There are 6 merged Pull Requests and 2 Proposed Pull Requests.
• There are 24 new Issues and 51 Closed Issues.

List of Contributors

• @admkakaroto, @Akkarinage, @aleos89, @Atemo, @anacondaqq, @Baalberith6, @Badarosk0, @CairoLee, @cold-hr, @cydh, @Dark8008, @dastgir, @DeveloperNube, @ernestfegarido, @Everade, @exneval, @hnomkeng, @Historica, @icxbb-xx, @joelolopez, @julia40124009, @lelouch22, @Lemongrass3110, @lighta, @lordganja, @MrAntares, @nanakiwurtz, @Paoly28, @RagnarokNova, @renniw, @RomeroMalaquias, @Rytech2, @secretdataz, @theultramage, @tmav94, @zackdreaver

Show your support to rAthena by submitting your Issue or Pull Requests!

[spoiler=You can help us too! (Yes, YOU! )]Currently rAthena uses GitHub Issues to handle bugs, server crash, pull requests, etc..
Most of the reports are fine, but some posts on our GitHub Issues are lacking of information needed to identify the possible cause, therefore it will make the dev to ask the same questions over and over again.
So, I'm here to show you a small tutorial on how to improve rAthena's GitHub Issues ^^

First of all, it will helps the devs a lot if the issue reporter put decent information on the top of the report.
You can copy paste the text below, and put it on top of your report:
[spoiler=GitHub Header Format]

Git Hash/Date: 
Client Date: 
Server Mode: Pre-RE/Renewal
Source/Script Mods: 
Descriptions:
How To Replicate:

Now I will explain what does the above lines means.
- Git Hash/Date = It means the referrence for each commits in GitHub, it can be used to identify which code has been changed/added. If you can't provide the Git Hash, at least you can use the date where you pulled/clone the repository. If you are still using SVN (which is not recommended anymore), you can provide the Revision Number instead.
[spoiler=Here I will show you how to get your current Git Hash]
1. Open up your Command Line Prompt' if you are on Windows, or 'Terminal' if you are on Linux. Navigate to your repository folder. For example if your rAthena folder is on F:\Folder\rAthena and currently you are on C:\, then you can type F:(enter)cd folder\rathena(enter). If your folder name contains space, enclose your folder name inside the "".
After you navigate to your repository folder, type: git show
(Actually you can use another commands like: git rev-parse HEAD or git rev-parse --short HEAD)
2. You will see your current Git Hash number which can be pasted using the short version (only it's first 7 characters).
For example: 5a0f8dc12ae1d0b2c3bf0a9fecc085719a28622b can be safely written as 5a0f8dc.
3. On the screenshot, I used a Git application (SmartGit), and it shows the same Git Hash number like the one on Command Line Prompt. There are lots of Git applications available, you can use whichever you want.
4. "master <3 origin" here is not "master loves origin" D:
It means that currently my local repo is '3 commits behind' from the master repo. In other words, someone has pushed some new commits (in this case, 3 commits) and I haven't pulled/fetch them. If I made some modification on my local repo but haven't pushed my commit to the master repo, it means that my local repo is 'ahead' of master repo.
5. Those dots are the commits details which is already pushed to the master repo.
6. HEAD means our 'current local repo'.

After reading the above explanations, I hope that no one will use the word 'latest git/hash/version/revision' anymore, because it's incorrect and confusing

- Client Date = Put with the client date you are using.
- Server Mode: Pre-RE/Renewal = Choose one, by deleting the unneeded one.
- Source/Script Mods = If you ever edited or applied some diffs from other sources, or you have edited the corresponding script, please describe it here. Because sometimes the report is invalid because of this reason.
- Descriptions = Describe your report here, if it's a server crash or compilation warning (or the others), please include the screenshot or the debug data too.
- How To Replicate = If you can, please describe on how to replicate the bugs you found, so it can be identified easier.

We are thankful if all issue reporters could follow the above format.

 

The rAthena community would like to say
"Happy New Year 2016!!"

[Nova]

Great to see the emulator doing this great. A bunch of great updates from everyone, and as usual, an impressive amount of skill fixes from Aleos.

[exneval]

well done