October Digest 2015

[Aleos]

October Digest 2015
The following digest covers the month of October, 2015.

Staff Changes

• @Aleos is now a Head Administrator
• @Brian is now a Supporting Admin
• @Maki is now a Supporting Admin
• @Akkarin is now a Community Contributor
• @Luciar is now a Community Contributor

Development Highlights

• CORE:
  • Corrected the Burning and Stun effects for Magma Eruption (7bc7b7e)
  • Added usage of enum values and cast cleanup in various places of source (78b6c15, a597e7b)
  • Backslide will now work if a player has the 'no knockback effect' active (c9c988a)
  • Fixed the questlog display for clients 2014-10-22 and on (45e50a3)
  • Fixed long broadcasts getting truncated (cef2f9e)
  • Fixed an issue with the pc_damage_log_add() not storing correctly (927d1e2)
  • Fixed Elementals getting removed incorrectly from deleted instances (857b82d)
  • Fixed a possible crash from Star Gladiator Warm skills (8c8c486)
  • Corrected Arms Cannon not giving splash damage (34c19ed)
  • Fixed a possible crash from Taekwon Counter (80b88b9)
  • Corrected skill cooldown overflow (573c7dc)
  • Corrected a few skills that use base stats to use stats stored in mmo_charstatus (ea497b2)
  • Warg Dash cannot be used while standing next to a monster (09e91d4)
  • Status effects that damage monsters will now give the EXP to the player (b385fd0)

• DATABASE:
  • Item Package update. Converted AegisName -> ItemID (640a0c5)
  • Corrected Blank Eyes location (64d2463)
  • Corrected Lighthalzen Bio Labs 3 monster drops (e0b24fc)
  • Updated item group Advanced Weapons Box (fd5e796)
  • Corrected locations for a few costumes (b6187aa, 581c236)

• SCRIPT:
  • None

• OTHERS:
  • Moved hard coded timestamps for logs to conf/logs.athena (1210bca)
  • @iteminfo will now properly display dropped items when 'mobinfo_type' is active (cef2f9e)
  • Script commands 'close' and 'end' will no longer stop a script if a shop is active (cef2f9e)
  • Quest IDs > 65535 is now supported (a2d8b81)
  • Corrected a few status checks to not have priority (030c4c5)
  • Fixed an issue where memory leak log was null on Windows (5a49b70)
  • Replaced macros 'min' and 'max' with some inline functions (214ff17)
  • Fixed an incorrect variable type, left over from 82467e1 (da94f41)
  • Item bonus documentation updates (efea117)
  • Added some newer NPC constants (ae98019)
  • Removed a useless parameter from elemental_delete() (dc533fe)
  • Removed some duplicate lines from .gitignore (d996590)

Statistics

• 8 authors have pushed 50 commits during this period.
• On master, 107 files have changed.
• There have been 5,571 additions and 4,963 deletions.
• There are 4 merged Pull Requests and 3 Proposed Pull Requests.
• There are 29 created Issues and 49 Closed Issues.

Show your support to rAthena by submitting your Issue or Pull Requests!

[spoiler=You can help us too! (Yes, YOU! )]Currently rAthena uses GitHub Issues to handle bugs, server crash, pull requests, etc..
Most of the reports are fine, but some posts on our GitHub Issues are lacking of information needed to identify the possible cause, therefore it will make the dev to ask the same questions over and over again.
So, I'm here to show you a small tutorial on how to improve rAthena's GitHub Issues ^^

First of all, it will helps the devs a lot if the issue reporter put decent information on the top of the report.
You can copy paste the text below, and put it on top of your report:
[spoiler=GitHub Header Format]

Git Hash/Date: 
Client Date: 
Server Mode: Pre-RE/Renewal
Source/Script Mods: 
Descriptions:
How To Replicate:

Now I will explain what does the above lines means.
- Git Hash/Date = It means the referrence for each commits in GitHub, it can be used to identify which code has been changed/added. If you can't provide the Git Hash, at least you can use the date where you pulled/clone the repository. If you are still using SVN (which is not recommended anymore), you can provide the Revision Number instead.
[spoiler=Here I will show you how to get your current Git Hash]
1. Open up your Command Line Prompt' if you are on Windows, or 'Terminal' if you are on Linux. Navigate to your repository folder. For example if your rAthena folder is on F:\Folder\rAthena and currently you are on C:\, then you can type F:(enter)cd folder\rathena(enter). If your folder name contains space, enclose your folder name inside the "".
After you navigate to your repository folder, type: git show
(Actually you can use another commands like: git rev-parse HEAD or git rev-parse --short HEAD)
2. You will see your current Git Hash number which can be pasted using the short version (only it's first 7 characters).
For example: 5a0f8dc12ae1d0b2c3bf0a9fecc085719a28622b can be safely written as 5a0f8dc.
3. On the screenshot, I used a Git application (SmartGit), and it shows the same Git Hash number like the one on Command Line Prompt. There are lots of Git applications available, you can use whichever you want.
4. "master <3 origin" here is not "master loves origin" D:
It means that currently my local repo is '3 commits behind' from the master repo. In other words, someone has pushed some new commits (in this case, 3 commits) and I haven't pulled/fetch them. If I made some modification on my local repo but haven't pushed my commit to the master repo, it means that my local repo is 'ahead' of master repo.
5. Those dots are the commits details which is already pushed to the master repo.
6. HEAD means our 'current local repo'.

After reading the above explanations, I hope that no one will use the word 'latest git/hash/version/revision' anymore, because it's incorrect and confusing

- Client Date = Put with the client date you are using.
- Server Mode: Pre-RE/Renewal = Choose one, by deleting the unneeded one.
- Source/Script Mods = If you ever edited or applied some diffs from other sources, or you have edited the corresponding script, please describe it here. Because sometimes the report is invalid because of this reason.
- Descriptions = Describe your report here, if it's a server crash or compilation warning (or the others), please include the screenshot or the debug data too.
- How To Replicate = If you can, please describe on how to replicate the bugs you found, so it can be identified easier.

We are thankful if all issue reporters could follow the above format.

[Stolao]

Good Work everyone who provided for those statistics.

[Nova]

Glad to see these back! And great job everyone.

[Azura Skyy]

 

• @Aleos is now a Head Administrator
• @Brian is now a Supporting Admin
• @Maki is now a Supporting Admin

 

What does this mean exactly for your control/say in everything? From discussions I've been a part of, the general consensus is that Brian and Maki still have full authority (at least primarily) over some things when their activity is non existent. Seems insulting in my honest opinion.

It may be to bold to ask, but is it at all possible that another staff member will replace them and actively work on the emulator?

 

EDIT: Seems rude to post such an aggressive question without thanking the people that worked hard over the last month. Well done.

With all due respect,

~Azura Skyy

Edited November 3, 2015 by AzuraSkyy

[Akkarin]

What does this mean exactly for your control/say in everything? From discussions I've been a part of, the general consensus is that Brian and Maki still have full authority (at least primarily) over some things when their activity is non existent. Seems insulting in my honest opinion.

It may be to bold to ask, but is it at all possible that another staff member will replace them and actively work on the emulator?

They are both active behind the scenes and will continue to be while Aleos remains the fore-figure of public authority. rAthena is hosted across 2 VMs on a Node that Maki pays for, which also has several VMs that both Brian and I utilise. As Aleos can now testify, when I said in the Staff area that the setup for rA was complicated, I meant it. Both Supporting Admins have in-depth knowledge of the 3rd Party tools that rAthena employs too.. so it seems a little pointless to remove them for non-existent activity on the forums and on Github when its those two people that keep the forums and our systems online.

 

The Admins of the rAthena forums are there to administrate various areas of rAthena, and not solely to "work on the emulator". That's why we have developers.

 

It's good to see that rAthena is in good hands with Aleos at the helm

[Azura Skyy]

As Aleos can now testify, when I said in the Staff area that the setup for rA was complicated, I meant it. Both Supporting Admins have in-depth knowledge of the 3rd Party tools that rAthena employs too.. so it seems a little pointless to remove them for non-existent activity on the forums and on Github when its those two people that keep the forums and our systems online.

This was genuinely helpful. I know I'm not the only person who feels like people are grandfathered in but don't do anything. That may sound rude, but that's the hard truth of it. Admittedly I still don't quite understand what they do, but it sounds like something. Out of curiosity, why are they paying for rA related stuff when there are a number of donators?

Regards,

~Azura Skyy