@Arealoot

[Dragonis1701]

So, I've looked at hercules' plugin for @arealoot and saw that it used greed's code to help do what it wanted. I decided to try and use it for myself and convert it over to rAthena but I'm having a bit of trouble. I don't dabble that much in the source, so I'm not very good at it but this is what I have so far:
 

Incorrect code removed.

It compiles but it does not change anything. It does give me a warning, though. This one: "1>c:\rathena\src\map\pc.c(4254): warning C4047: '==' : 'int (__cdecl *)(map_session_data *,flooritem_data *)' differs in levels of indirection from 'int'" I  think I understand what it means but I'm not sure how to fix it. Please help. =X

Edited December 9, 2015 by Dragonis1701

[Dragonis1701]

Care to share?

 

I've been trying my hand at this on and off for months now.

 

 

Can you share your code?

Oh, hey guys. Sorry, I didn't know you replied to this topic. I'm quoting you both so you both get a notification. Here is the code:

void clif_parse_TakeItem(int fd, struct map_session_data *sd)
{
    struct flooritem_data *fitem;
    int map_object_id;
    int skill_greed(struct block_list *bl, va_list ap);

    //First we declare a variable that gets the return value
    int debug_i = 0;

    map_object_id = RFIFOL(fd,packet_db[sd->packet_ver][RFIFOW(fd,0)].pos[0]);

    fitem = (struct flooritem_data*)map_id2bl(map_object_id);
    do {
        if (pc_isdead(sd)) {
            clif_clearunit_area(&sd->bl, CLR_DEAD);
            break;
        }

        if (fitem == NULL || fitem->bl.type != BL_ITEM || fitem->bl.m != sd->bl.m)
            break;

        if (pc_cant_act(sd))
            break;
        
        if (sd->state.arealoot == 1) {
        //Now we give the variable
        debug_i = map_foreachinrange(skill_greed,&sd->bl,3,BL_ITEM,&sd->bl);

        //Now we print it to the map-server console so you can see what it is while playing
        //ShowDebug("debug_i=%d", debug_i);

        //Give fail packet if no item was looted
        if(debug_i == 0)
            break;
        }
        else {
        if (!pc_takeitem(sd, fitem))
            break;
        }
        return;
    } while (0);
    // Client REQUIRES a fail packet or you can no longer pick items.
    clif_additem(sd,0,0,6);
}

That code is located in clif.c. I also added a command @arealoot in the atcommand.c. If you need that code as well, just let me know.

[Dragonis1701]

So, I worked on it some more and found that using the already existing code was better. So, now I have it where the code is like this:

Incorrect code removed.

And now with this code, it will clear multiple items but it will not loot multiple items. Is there a command I'm missing that can provide this function?

Got it to work with Playtester's help. ^^

Edited December 9, 2015 by Dragonis1701

[Eyjafjallajokull]

Care to share?

 

I've been trying my hand at this on and off for months now.

[Meister]

Can you share your code?

[Meister]

 

Care to share?

 

I've been trying my hand at this on and off for months now.

 

 

Can you share your code?

Oh, hey guys. Sorry, I didn't know you replied to this topic. I'm quoting you both so you both get a notification. Here is the code:

 

void clif_parse_TakeItem(int fd, struct map_session_data *sd)
{
    struct flooritem_data *fitem;
    int map_object_id;
    int skill_greed(struct block_list *bl, va_list ap);

    //First we declare a variable that gets the return value
    int debug_i = 0;

    map_object_id = RFIFOL(fd,packet_db[sd->packet_ver][RFIFOW(fd,0)].pos[0]);

    fitem = (struct flooritem_data*)map_id2bl(map_object_id);
    do {
        if (pc_isdead(sd)) {
            clif_clearunit_area(&sd->bl, CLR_DEAD);
            break;
        }

        if (fitem == NULL || fitem->bl.type != BL_ITEM || fitem->bl.m != sd->bl.m)
            break;

        if (pc_cant_act(sd))
            break;
        
        if (sd->state.arealoot == 1) {
        //Now we give the variable
        debug_i = map_foreachinrange(skill_greed,&sd->bl,3,BL_ITEM,&sd->bl);

        //Now we print it to the map-server console so you can see what it is while playing
        //ShowDebug("debug_i=%d", debug_i);

        //Give fail packet if no item was looted
        if(debug_i == 0)
            break;
        }
        else {
        if (!pc_takeitem(sd, fitem))
            break;
        }
        return;
    } while (0);
    // Client REQUIRES a fail packet or you can no longer pick items.
    clif_additem(sd,0,0,6);
}

That code is located in clif.c. I also added a command @arealoot in the atcommand.c. If you need that code as well, just let me know.

 

 

Can you post the full code or share it via message? Thanks!

[Dragonis1701]

atcommand.c

/*==========================================
 * @arealoot
 *------------------------------------------*/
ACMD_FUNC(arealoot) {
    if (sd->state.arealoot) {
        sd->state.arealoot = 0;
        clif_displaymessage(sd->fd,"Arealoot is now disabled.");
        return 0;
    }

    sd->state.arealoot = 1;
    clif_displaymessage(sd->fd,"Arealoot is now enabled.");
    return 0;
}

void atcommand_basecommands(void) {
 
AtCommandInfo atcommand_base[] = {
 
ACMD_DEF(arealoot),

Edited December 9, 2015 by Dragonis1701

[Meister]

 

atcommand.c

/*==========================================
 * @arealoot
 *------------------------------------------*/
ACMD_FUNC(arealoot) {
    if (sd->state.arealoot) {
        sd->state.arealoot = 0;
        clif_displaymessage(sd->fd,"Arealoot is now disabled.");
        return 0;
    }

    sd->state.arealoot = 1;
    clif_displaymessage(sd->fd,"Arealoot is now enabled.");
    return 0;
}

 

The first 2 post goes to pc.c? the void code goes to clif.c and last one is atcommand.c?

[Dragonis1701]

Nah, the pc.c codes are not right. You just do the last two codes I posted: the one in clif.c and the one in atcommand.c

[a91323]

pc.h

bool arealoot;

[Meister]

 

pc.h

bool arealoot;

 

where do you add this?

Nah, the pc.c codes are not right. You just do the last two codes I posted: the one in clif.c and the one in atcommand.c

 

 

i'm having error because of the state->arealoot 

Edited December 9, 2015 by Meister

[Dragonis1701]

Are you using a different emulator? My code says sd->state.arealoot not struct s_state.

[Meister]

Are you using a different emulator? My code says sd->state.arealoot not struct s_state.

 

using rAthena only.

[Dragonis1701]

Then the code should work for you if you copied it correctly.

[Meister]

Then the code should work for you if you copied it correctly.

 

I copied it correctly, mind attaching .txt file for it?

[Dragonis1701]

It's going to be exactly what I already posted but okay.

text.txt

Edited December 10, 2015 by Dragonis1701

[Meister]

It's going to be exactly what I already posted but okay.

 

I think its not on pc.c its on clif.c the one on the text.

[Eyjafjallajokull]

Thank you, Dragonis1701. Sorry for the belated gratitude.

[FelipeMartins]

its not compiling

 

any one can help us?

 

guys help me !!!

[Sirique]

On 17/02/2018 at 8:02 PM, Felipe Martins said:

guys help me !!!

I get the same error as he does. Anything on that?!

[jame156]

me too i get this error

[wakefield21]

bump! we need this amazing code

[Metahego]

Finally i make this .diff manualy, it work on my rathena's version

Edit: Resolved some issues, and added possibility to config range in battle_conf
But don't know why, when i put range to 10 that make not difference with 3

 

@arealoot.diff

Edited February 3, 2019 by Metahego

[wakefield21]

@Metahego im currently using the latest rathena, and i can't compile my server it causes errors. Would you like to help me resolve this? tyvm

 

[Metahego]

wakefield21 Can you send me your compile errors ?

Edited February 24, 2019 by Metahego

[wakefield21]

@Metahego i already fixed the compiling part, then i stumbled on this error which i think is critical.

if the command @arealoot is disabled and you drop an item example a red potion and pick it up the item will be duplicated and there will be an error on the console like this one.

now if the command @arealoot is enabled there will be no errors on the console and there will be no item duplication.

I hope this will be fixed asap as this command is very helpful.