March Digest 2015

[nanakiwurtz]

March Digest 2015
The following digest covers the month of March, 2015.

Staff Changes

• None

Development Highlights

• CORE:
  • Packet Obfuscation feature implemented (f05119b)
  • Expanded message length for e_msg in pc_useitem to CHAT_SIZE_MAX (5c24534)
  • Fixed unlearnable Taekwon's skill (Issue:#317)
  • Fixed monster's magical skill damage calculation (Issue:#321)
  • Added missing Renewal calculations for Mercenary (1b6be4e)
  • Fixed MATK calculation for players, monsters, homunculus, mercenaries, etc (9f6f55c)
  • Fixed script_free_code on script.c (Issue:#335)
  • Auto disable the Packet Obfuscation feature if using client version below than 2011-08-17 (bae469e)
  • Removed some duplicate codes in /src/char folder (d92a8df)
  • Fixed wrong mapname in party info window when member is in instance (17ffda6)
  • Instance code cleanup (fb01b02)
  • Added missing monster transformation bonuses and updateed the Status Icons with newer icons (231710c)
  • Added map names check for instance entrance and maplist (0e5997e)
  • Basic 'Unit Controller' script commands are implemented (2cee5b6, 2dc38e7)
  • A little clean up in 'getunitdata' code (e93afad)
  • Fixed map-server crashed by Crimson Marker skill (49a0b55)
  • Reverted 'mercenary_create' command to don't return the mercenary game ID (Issue:#361)
  • NPC Market Shop feature implemented (7d929a0)
  • Old MATK calculation for Renewal monsters are being used as temporary fix (Issue:#321)
  • Fixed map-server crashed by GentleTouch skills (Issue:#366)
  • Fixed 'cashshop' warning and 'pointshop' code (Issue:#368)
  • Added Monster Loot config (3028c87)
  • Fixed 'ADJUST_SKILL_DAMAGE' code (Issue:#350)

• DATABASE:
  • Fixed Kaahi skill duration (Issue:#320)
  • Updated Arrow Shower skill to follow recent Renewal data (Issue:#310)
  • Fixed Frigg's Song skill duration (Issue:#145)
  • Fixed Piercing Shot skill damage calculation (Issue:#202)
  • Fixed Blood Lust skill HP leeching (Issue:#272)
  • Fixed Homunculus ATK and ASPD calculation (Issue:#298)
  • Updated Item DB and Item Combo Set (45e1bf2, 96c49c8, d34a12e, d49d66b, 212f5db)
  • Fixed Dragon Breath skill damage calculation (Issue:#167)
  • Fixed Reverberation skill timer (Issue:#270)
  • Fixed Camouflage skill behaviour against targeting skills (Issue:#332)
  • Fixed Full Throttle skill SP drain amount, movement speed and cooldown value (9f6f55c)
  • Fixed Mix Cooking, Make Bomb, Special Pharmacy, Change Material, and Rune Mastery success and fail animations (9f6f55c)
  • Fixed trap's HP and knockback issue (Issue:#338)
  • Fixed Dragon breath skill type checks and adjusted Camouflage to account for ground-based skills (5a9ffc4)
  • Fixed Stealth Field skill SP drain and speed penalty (Issue:#176)
  • Fixed Auto Shadow Spell activation failure (Issue:#331)
  • Updated Phantom Thrust skill effect so it can be used on party members (Issue:#340)
  • Complete recheck of item_db, item_trade, item_combo_db and pet_db (5a0f8dc, acffcba)
  • Corrected Flash Combo weapon ATK and to cancel skill cast when target is more than 2 cells away (Issue:#119)
  • Corrected Kings Grace to only cast on guild members in versus type maps, added missing effects and cooldown update (Issue:#148)
  • Offertorium and Magnificat now cancel each other out (Issue:#341)
  • Champion mobs implemented (ffffb0ad)
  • Added skill database of Nightmare Glast Heim & Champion mobs (5ec1b24)
  • Fixed Cart Cannon skillratio (Issue:#360)

• SCRIPT:
  • Flavius Battleground Crystals bug fixed (Issue:#231, 76df76b)
  • Corrected Tiucknuc mob name into Tiyanak (8276765)
  • Champion Mobs natural spawn area added (5ce3c68)
  • Dungeon Sign Posts added (1e8aa4b)

• OTHERS:
  • Fixed some compile warnings when Packet Obfuscation is disabled (1be5665)
  • Fixed athena-start status command (Issue:#257)
  • Fixed some compile warnings in pc.c and skill.c (Issue:#309, Issue:#313)
  • Packet Obfuscation feature is now enabled by default (1b69b98)
  • Fixed 'make tools' target for ./configure (d1eeda3)
  • Updated script_commands.txt, const.txt and status_change.txt (d951fab, c7062e5)

Statistics

• 5 authors have pushed 20 commits during this period.
• On master, 34 files have changed.
• There have been 7,304 additions and 726 deletions.
• There are 2 merged Pull Requests and 2 Proposed Pull Requests.
• There are 5 created Issues and 10 Closed Issues.
• List of Contributors: @icxbb-xx, @aleos87, @cydh, @anacondaqq, @Playtester, @reigneil, @SakrayRO, @MrAntares, @vehona, @RagnarokNova, @RadianFord, @nanakiwurtz, @trickyloki3, @julia40124009, @exneval, @botka4aet, @lighta, @carl820912, @Inzanity99, @raynra, @BraisGabin, @musashi076, @Skormie, @Lemongrass3110, @euphyy, @zackdreaver, @Atemo, @cawogeek

 Show your support to rAthena by submitting your Issue or Pull Requests!

[spoiler=You can help us too! (Yes, YOU! )]Currently rAthena uses GitHub Issues to handle bugs, server crash, pull requests, etc..
Most of the reports are fine, but some posts on our GitHub Issues are lacking of information needed to identify the possible cause, therefore it will make the dev to ask the same questions over and over again.
So, I'm here to show you a small tutorial on how to improve rAthena's GitHub Issues ^^

First of all, it will helps the devs a lot if the issue reporter put decent information on the top of the report.
You can copy paste the text below, and put it on top of your report:
[spoiler=GitHub Header Format]

Git Hash/Date: 
Client Date: 
Server Mode: Pre-RE/Renewal
Source/Script Mods: 
Descriptions:
How To Replicate:

Now I will explain what does the above lines means.
- Git Hash/Date = It means the referrence for each commits in GitHub, it can be used to identify which code has been changed/added. If you can't provide the Git Hash, at least you can use the date where you pulled/clone the repository. If you are still using SVN (which is not recommended anymore), you can provide the Revision Number instead.
[spoiler=Here I will show you how to get your current Git Hash]
1. Open up your Command Line Prompt' if you are on Windows, or 'Terminal' if you are on Linux. Navigate to your repository folder. For example if your rAthena folder is on F:\Folder\rAthena and currently you are on C:\, then you can type F:(enter)cd folder\rathena(enter). If your folder name contains space, enclose your folder name inside the "".
After you navigate to your repository folder, type: git show
(Actually you can use another commands like: git rev-parse HEAD or git rev-parse --short HEAD)
2. You will see your current Git Hash number which can be pasted using the short version (only it's first 7 characters).
For example: 5a0f8dc12ae1d0b2c3bf0a9fecc085719a28622b can be safely written as 5a0f8dc.
3. On the screenshot, I used a Git application (SmartGit), and it shows the same Git Hash number like the one on Command Line Prompt. There are lots of Git applications available, you can use whichever you want.
4. "master <3 origin" here is not "master loves origin" D:
It means that currently my local repo is '3 commits behind' from the master repo. In other words, someone has pushed some new commits (in this case, 3 commits) and I haven't pulled/fetch them. If I made some modification on my local repo but haven't pushed my commit to the master repo, it means that my local repo is 'ahead' of master repo.
5. Those dots are the commits details which is already pushed to the master repo.
6. HEAD means our 'current local repo'.

After reading the above explanations, I hope that no one will use the word 'latest git/hash/version/revision' anymore, because it's incorrect and confusing

- Client Date = Put with the client date you are using.
- Server Mode: Pre-RE/Renewal = Choose one, by deleting the unneeded one.
- Source/Script Mods = If you ever edited or applied some diffs from other sources, or you have edited the corresponding script, please describe it here. Because sometimes the report is invalid because of this reason.
- Descriptions = Describe your report here, if it's a server crash or compilation warning (or the others), please include the screenshot or the debug data too.
- How To Replicate = If you can, please describe on how to replicate the bugs you found, so it can be identified easier.

We are thankful if all issue reporters could follow the above format

[spoiler=If you didn't follow it, we will do this to you... ]

[Nova]

Great month guys. It's awesome to see the emulator improve.

[Tranquility]

Thanks for the hard work!

Glad to be part of this community.

[Whathell]

Awesome month! 

[Kido]

I'm so happy to see that rAthena keeps improving a lot, love you all <3      way to go!