Kreustoo

Okay my bad, tested it with reloadnpc, @iraciz From d3f15f841b1a0f563925e8710c3b798360a5d8c7 Mon Sep 17 00:00:00 2001 From: Kreustoo <[email protected]> Date: Sat, 29 Aug 2020 21:03:23 +0200 Subject: [PATCH] ClickTheNinja, Fix the hideon hideoff --- scripts/Click The Ninja/ClickTheNinja.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Click The Ninja/ClickTheNinja.txt b/scripts/Click The Ninja/ClickTheNinja.txt index 04dc3f6..4a1c1bc 100644 --- a/scripts/Click The Ninja/ClickTheNinja.txt +++ b/scripts/Click The Ninja/ClickTheNinja.txt @@ -61,7 +61,7 @@ prontera,149,150,4 script Ninja Click 637,{ //!!Modify!! Position for(.@i = 0;.@i < .NbNpcSession;.@i++){ .@npcName$ = "EvNinjaTrainDup"+.Current; movenpc .@npcName$,rand(.XMin,.XMax),rand(.YMin,.YMax); - enablenpc .@npcName$; + hideoffnpc .@npcName$; .Current++; if(.Current > .MaxNpc) .Current = 1; @@ -109,7 +109,7 @@ prontera,149,150,4 script Ninja Click 637,{ //!!Modify!! Position if(.NbNpcSession < 1) .NbNpcSession = 1; for(.@i = 1;.@i <= .MaxNpc;.@i++) - disablenpc "EvNinjaTrainDup"+.@i; + hideonnpc "EvNinjaTrainDup"+.@i; mapannounce .@mapnameNPC$,"The event started, be the first to click on the npc!",bc_all; initnpctimer; end;

@iraciz @@ -125,7 +126,7 @@ prontera,149,150,4 script Ninja Click 637,{ //!!Modify!! Position end; } npctalk "Training Ninja: Damn! "+strcharinfo(0)+" got me!"; - disablenpc strnpcinfo(3); + hideonnpc strnpcinfo(3); for(.@i = 0;.@i< getarraysize(.Rewards);.@i =.@i +2){ getitem .Rewards[.@i],.Rewards[.@i+1]; } I relaunched the game to test and this little fix should fix the crash, tell me if it does the job or not

hello, I think you can catch with bindatcmd the go and check if player hp are 0 and do @alive instead of @go (and let @go happen if you don't need to do anything about it)

Hello, Add a 1 cell wall and tp the player inside/outside using a ontouch?

Hello, There's a mecanism inside rathena: https://rathena.org/board/topic/108140-storage-types-optimization/

Oh, I think to prevent that you need to move the npc then disable it, I'll do a patch for this then. Thanks for the report!

Adding MO_TRIPLEATTACK level 11 when wearing is a huge buff, because now, they don't need AT ALL the skill, I'd rather put in the item script, getting the level of the skill +1 (forgot how but there's a script command to check it, checkskill?).

Hello, Triple attack is an auto cast right? So maybe add a check inside your item to autocast tripleattack if refine +20? Dunno how it adds to the bas chance to triple attack so may need to test what happens and put the right values.

Hello, @foenne524 you could post how you did it so if someone has the same problem and see your post, they have the answer too :).

In my answer there's already the loop, you just had to copy/paste to replace, but whatever: function script CustomBox { set .@Total,65; setarray .@P1[0],90,983,5; //Black Dyestuff setarray .@P2[0],91,981,5; //Violet Dyestuff setarray .@P3[0],93,13517,1; //YGGBOX setarray .@P4[0],94,12534,1; //YGGSEED setarray .@P5[0],80,3016,1; //HOKAGEHAT setarray .@P6[0],81,3696,1; //LUFFYHAT setarray .@P7[0],85,740,10; //PUPPET setarray .@P8[0],89,720,10; //AQUAMARINE setarray .@P9[0],87,14176,1; //ENRICHEDELU setarray .@P10[0],88,14177,1; //ENRICHEDORI setarray .@P11[0],60,50005,1; //PREMIUMCREDIT setarray .@P12[0],70,3676,1; //HOLLOWMASK setarray .@P13[0],75,3678,1; //ROBOEARS setarray .@P14[0],50,19130,1; //MAGICEYES setarray .@P15[0],51,5184,1; //CAPTAINSHAT setarray .@P16[0],52,8327,1; //EVOLVED POOPOO setarray .@P17[0],53,3782,1; //DARKLORDHELM setarray .@P18[0],54,18534,1; //FANCYPHANTOM setarray .@P19[0],55,5325,1; //ROBOEYE setarray .@P20[0],51,19176,1; //FALLENANGELBLESSING setarray .@P21[0],56,5517,1; //HAWKEYES setarray .@P22[0],57,3661,1; //DEVILING WINGS setarray .@P23[0],58,3000,1; //ANGELINGWINGS setarray .@P24[0],59,3001,1; //ARTICWINGS setarray .@P25[0],60,3003,1; //DEMONWINGS setarray .@P26[0],61,3005,1; //GARGOYLEWINGS setarray .@P27[0],62,3007,1; //PHOENIXWINGS setarray .@P28[0],63,3008,1; //TORNWINGS setarray .@P29[0],64,3002,1; //BLACKBUTTERFLYWING setarray .@P30[0],65,3009,1; //WHITEBUTTERFLYWING setarray .@P31[0],65,2726,1; //ICARUSWINGS setarray .@P32[0],40,7828,1; //BRAVERYBADGE setarray .@P33[0],41,45078,1; //NEKOHOOD setarray .@P34[0],42,20073,1; //MVPHAT setarray .@P35[0],43,rand(45066,45072),1; //BUNDANNA setarray .@P36[0],40,rand(45099,45101),1; //RUNES setarray .@P37[0],40,45084,1; //BLACKRUNES setarray .@P38[0],40,rand(45026,45028),1; //BLACKAURA-PINK setarray .@P39[0],40,rand(45062,45065),1; //BLACKAURA-WHITE setarray .@P40[0],20,rand(3515,3526),1; //DRAGONWEAPON setarray .@P41[0],20,28605,1; //DRAGONBOOK setarray .@P42[0],20,3536,1; //DRAGONSHURIKEN setarray .@P43[0],15,rand(45211,45214),1; //FUSHIONVALKYIRE setarray .@P44[0],10,rand(8032,8033),1; //DIABLOSPIRIT setarray .@P45[0],10,20727,1; //BRILLIANTGOLDEN setarray .@P46[0],9,82517,1; //INVOKERCAPE setarray .@P47[0],2,4549,1; //UPDMAYA setarray .@P48[0],3,4359,1; //SINXCARD setarray .@P49[0],3,4357,1; //LKCARD setarray .@P50[0],3,4361,1; //WSCARD setarray .@P51[0],3,4363,1; //HIGHPRIESTCARD setarray .@P52[0],3,4365,1; //HIGHWIZARDCARD setarray .@P53[0],5,4128,1; //GTB setarray .@P54[0],7,3742,1; //GOLDENSWORDAURA setarray .@P55[0],4,40016,1; //DRAGONRING setarray .@P56[0],5,rand(40006,40012),1; //DRAGONSET setarray .@P57[0],1,rand(4480,4504),1; //SEALED setarray .@P58[0],1,rand(4535,4544),1; //SEALED setarray .@P69[0],100,7227,rand(1,5); // TCG setarray .@P60[0],100,7227,rand(5,10); // TCG setarray .@P61[0],95,6767,rand(1,10); //MVPCOIN setarray .@P62[0],96,3100,rand(1,10); //CREDIT setarray .@P63[0],97,7608,rand(1,5); //LOTTITICKET setarray .@P64[0],96,6420,rand(1,10); //HOURLYCOIN setarray .@P65[0],2,rand(40033,40034),1; //VIPBOX for(.@count = 0;.@count < 10;.@count++){ do{ set .@i, rand(1,.@Total); }while( rand(1,100) > getd(".@P"+.@i+"[0]") ); for(set .@j,1; .@j<getarraysize(getd(".@P"+.@i)); set .@j,.@j+2) { getitem getd(".@P"+.@i+"["+.@j+"]"), getd(".@P"+.@i+"["+(.@j+1)+"]"); if (!.@k[0]) { set .@gz,.@i; setarray .@k[0], getd(".@P"+.@i+"["+.@j+"]"), getd(".@P"+.@i+"["+(.@j+1)+"]"); break; } } if( .@gz && .@gz <= 10 ) // 10% equal or below will announce announce "Congratulations! "+strcharinfo(0)+" just received "+getitemname(.@k[0])+" x "+.@k[1]+" From Supply Box",0; specialeffect2 248; } end; }

Hello, I had a problem one time with that, you can read my little topic about what I tested/done: Maybe that's really not related, but by any chance ¯\_(ツ)_/¯

Hello, When opening your item, check your map error, it'll tell you if it can't find "CustomBox", if that's the case, you have an error when loading your function that you have to correct. If not, that's what Patskie said, you have a problem in your function directly that does not work as you think and you need to debug it.

Hello, You can put a for around the logical that goes from 0 to 10 for(.@count = 0;.@count < 10;.@count++){ do{ set .@i, rand(1,.@Total); }while( rand(1,100) > getd(".@P"+.@i+"[0]") ); for(set .@j,1; .@j<getarraysize(getd(".@P"+.@i)); set .@j,.@j+2) { getitem getd(".@P"+.@i+"["+.@j+"]"), getd(".@P"+.@i+"["+(.@j+1)+"]"); if (!.@k[0]) { set .@gz,.@i; setarray .@k[0], getd(".@P"+.@i+"["+.@j+"]"), getd(".@P"+.@i+"["+(.@j+1)+"]"); break; } } if( .@gz && .@gz <= 10 ) // 10% equal or below will announce announce "Congratulations! "+strcharinfo(0)+" just received "+getitemname(.@k[0])+" x "+.@k[1]+" From Supply Box",0; specialeffect2 248; }

Isn't that hercules src? It seems you have a problem in "hatless_pre_clif_changeloook" but don't know anything about it to help you.

Hello, Nobody can help you without a crash log: https://github.com/rathena/rathena/wiki/GDB