Warlock Summoning Skill Problem

[Frhysthia]

i tested summon fire , water , lightning, and stone ball, but then.

this is example, i use summon lightning ball level 1 5times. ..it does not stock 5 lightning balls, it only stock 1 lightning ball,. but when i use level 5 summon lightning ball 5times., it stocks 5 lightning ball, where can i fix this when i cast level 1 summoning stone 5times it will stack 5 stones? thanks to those will help me in advance 

 

Ooops. sorry wrong thread.

Edited September 7, 2014 by Frhysthia

[Antares]

It was a bug.

http://rathena.org/board/tracker/issue-9120-warlock-summon-elemental-balls/

[t3quila]

i don't think so it was a bug, because in official idro it wasn't bug until now, it summon 5 balls in level 1.

you can change this in skill.c (if you want back turn effect the old one)

from

		{
			short element = 0, sctype = 0, pos = -1, j = 0;
			struct status_change *sc = status_get_sc(src);

			if( !sc )
				break;

			for( i = SC_SPHERE_1; i data[i] )
					sctype = i; // Take the free SC
				if( sc->data[i] ) {
					pos = max(sc->data[i]->val2,pos);
					j++;
				}
			}

			if( !sctype || j >= skill_lv ) {
				if( sd ) // No free slots to put SC
					clif_skill_fail(sd,skill_id,USESKILL_FAIL_SUMMON,0);
				break;
			}

			pos++; // Used in val2 for SC. Indicates the order of this ball
			switch( skill_id ) { // Set val1. The SC element for this ball
				case WL_SUMMONFB:    element = WLS_FIRE;  break;
				case WL_SUMMONBL:    element = WLS_WIND;  break;
				case WL_SUMMONWB:    element = WLS_WATER; break;
				case WL_SUMMONSTONE: element = WLS_STONE; break;
			}

			sc_start4(src,src,(enum sc_type)sctype,100,element,pos,skill_lv,0,skill_get_time(skill_id,skill_lv));
			clif_skill_nodamage(src,bl,skill_id,0,0);
		}
		break;

to this

{
			short element = 0, sctype = 0, pos = -1;
			struct status_change *sc = status_get_sc(src);
		
			if( !sc ) break;

			for( i = SC_SPHERE_1; i data[i] )
					sctype = i; // Take the free SC
				if( sc->data[i] )
					pos = max(sc->data[i]->val2,pos);
			}

			if( !sctype )
			{
				if( sd ) // No free slots to put SC
					clif_skill_fail(sd,skill_id,USESKILL_FAIL_SUMMON,0);
				break;
			}

			pos++; // Used in val2 for SC. Indicates the order of this ball
			switch( skill_id )
			{ // Set val1. The SC element for this ball
				case WL_SUMMONFB:    element = WLS_FIRE;  break;
				case WL_SUMMONBL:    element = WLS_WIND;  break;
				case WL_SUMMONWB:    element = WLS_WATER; break;
				case WL_SUMMONSTONE: element = WLS_STONE; break;
			}

			sc_start4(src,src,(enum sc_type)sctype,100,element,pos,skill_lv,0,skill_get_time(skill_id,skill_lv));
			clif_skill_nodamage(src,bl,skill_id,0,0);
		}
		break;

i almost forgot..look it this (in iro) same as in ratemyserver script.its level is only affected by damage, duration and sp cost.for me this is very disappointing to know that http://rathena.org/board/tracker/issue-9120-warlock-summon-elemental-balls/ this custom request like this can make aleos replace its original script on last git. (sorry not offens aleos )

[Antares]

It was reverted (renewal update removed that behav). Update to latest GIT.

[Frhysthia]

@ t3quila

Error in compiling.

skill.c: At top level:

skill.c:10236: error: expected identifier or '(' before 'if'

skill.c:10242: error: expected identifier or '(' before 'if'

skill.c:10247: error: expected identifier or '(' before 'if'

skill.c:10260: warning: data definition has no type or storage class

skill.c:10260: warning: type defaults to 'int' in declaration of 'map_freeblock_unlock'

skill.c:10261: error: expected identifier or '(' before 'return'

skill.c:10262: error: expected identifier or '(' before '}' token

make[1]: *** [obj_sql/skill.o] Error 1

Edited October 14, 2014 by Frhysthia

[t3quila]

i'm so sorry.. i forgot about

{

before

short element

actually no prob in my skill.c, i wrote it like this:

http://pastebin.com/raw.php?i=bfzpBxai