Peopleperson49 Posted January 1, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Share Posted January 1, 2014 The import db addition is awesome. Is that all that will be or are you going to make additonal files there? The idea behind import files was always to make updating easier and faster. That makes the person doing the update happy and also is good for the emulator because easier updates mean users do more frequent updates and therefore find more bugs especially in newer stuff. Peopleperson49 db/import/castle_db db/import/create_arrow_db db/import/map_index db/import/mob_avail db/import/produce_db There probably should also be an import for the files that are split between pre and re. db/import/re/item_combo_db db/import/re/item_delay db/import/re/item_noequip db/import/re/item_tradedb/import/re/skill_cast_dbdb/import/re/skill_castnodex_dbdb/import/re/skill_dbdb/import/re/skill_nocast_dbdb/import/re/skill_require_dbdb/import/re/skill_unit_db Quote Link to comment Share on other sites More sharing options...
Kichi Posted January 1, 2014 Group: Members Topic Count: 25 Topics Per Day: 0.01 Content Count: 509 Reputation: 80 Joined: 11/20/11 Last Seen: October 3, 2020 Share Posted January 1, 2014 totaly agree /nothats good idea to import all dbsto make server owner easy add new item from rathena and it won't conflict with the custom from owner Quote Link to comment Share on other sites More sharing options...
Lighta Posted January 1, 2014 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted January 1, 2014 Peopleperson49, All those are currently available for import : db/import/re/item_combo_db db/import/re/item_delay db/import/re/item_noequip db/import/re/item_tradedb/import/re/skill_cast_dbdb/import/re/skill_castnodex_dbdb/import/re/skill_dbdb/import/re/skill_nocast_dbdb/import/re/skill_require_dbdb/import/re/skill_unit_db But in import folder you don't need to keep the re or pre-re directory as you only want to overwritte them, or you may want to keep it for irk what reason but then that up to you to edit the src for so. (cause we could have ton of specific subdir and such) Now some db ain't available in import/ dir yet but that will be changed soon enough. I'll do the list of available db taht could be overwritten. Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 1, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 1, 2014 Peopleperson49, All those are currently available for import : db/import/re/item_combo_db db/import/re/item_delay db/import/re/item_noequip db/import/re/item_trade db/import/re/skill_cast_db db/import/re/skill_castnodex_db db/import/re/skill_db db/import/re/skill_nocast_db db/import/re/skill_require_db db/import/re/skill_unit_db But in import folder you don't need to keep the re or pre-re directory as you only want to overwritte them, or you may want to keep it for irk what reason but then that up to you to edit the src for so. (cause we could have ton of specific subdir and such) Now some db ain't available in import/ dir yet but that will be changed soon enough. I'll do the list of available db taht could be overwritten. I understand not using the re or pre. I didn't realize those other files were there to import. Which files would I use for those, or do I need to make my own file there? I saw the 7 files you currently have in the import folder. I look foward to using this feature from here out!!! Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Euphy Posted January 1, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 1, 2014 You can create your own files, if one isn't already there. Do you think it'd be beneficial to have empty files for all the databases, or could we simply do a better job documenting it? Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 1, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 1, 2014 I think all files that have an import frature should be there to eliminate confusion or were setting ourselves up for more questions later like I asked. I had no idea. That is also how you do it inthe conf import and it seems to be working. Thanks. Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Lighta Posted January 2, 2014 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted January 2, 2014 I just added the file that could be overwritten, should be all db actually but feel free to do send me add a note if a file is missing or unread. Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 2, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 2, 2014 (edited) With the skill_tree import it seems like you can easily add or override skills from a class, but is it possible to make it so you can remove a skill from a class? Same with guild/homun skill trees? Peopleperson49 Edited January 2, 2014 by Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Euphy Posted January 2, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 2, 2014 While being able to delete entries would be convenient, I feel that it's outside the scope of 'import' files. Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 2, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 2, 2014 (edited) I thought the point of the import files was to all you to import your server modifications without touching the original files in anyway. That is how it saves time with updating. Whether its adding, modifying, or even removing items, its still importing. I was going to say that there are probably other files that you should be able to removed entries such as mob_branch, lol. Peopleperson49 Can we import custom items added to groups such as item_bluebox, item_cardalbum, item_giftbox, item_misc, item_violetbox, or etc...? There are not import template for them? Peopleperson49 Edited January 2, 2014 by Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Euphy Posted January 2, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 2, 2014 To delete entries, you'd have to create a separate command for every database which would remove entries, and check for every entry whether it's being added or deleted. It's inefficient and not really worth the effort. Quote Link to comment Share on other sites More sharing options...
sietse11 Posted January 4, 2014 Group: Members Topic Count: 44 Topics Per Day: 0.01 Content Count: 127 Reputation: 7 Joined: 02/10/13 Last Seen: February 1, 2019 Share Posted January 4, 2014 So if I scrolled over this right. You are saying it is not possible to delete entries from stuff like mob_branch? Why not just tell people to copy the file they want to change to said directory, and them have them change that file. This way you can update all original files as much as you want, as long as the server would always prioritize the import folder. Now did this make any sense, or did I completely miss the point here? Anyways, back to looking for ai4rei's guide on 9 digit damage...(I don't even know how I got here) Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 4, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 4, 2014 The checks don't seem like they would be that much. There is no sql table for skill_tree that I know of. I was proposing making a way to nullfys an entry in the skill_tree. Peopleperson49 Original Code 4049,468,7,453,1,0,0,0,0,0,0,0,0 //SL_STUN#Estern# 4049,469,10,467,7,468,7,0,0,0,0,0,0 //SL_SMA#Esma# 4049,470,7,454,1,0,0,0,0,0,0,0,0 //SL_SWOO#Esu# Db reads this to remove a code for esma the same way it updates the skill tree for the import. 4049,469,-1 Quote Link to comment Share on other sites More sharing options...
Euphy Posted January 4, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 4, 2014 Why not just tell people to copy the file they want to change to said directory, and them have them change that file. This way you can update all original files as much as you want, as long as the server would always prioritize the import folder. You can imagine that the vast majority of users doing this would never update their databases again. Definitely not what we want. I was proposing making a way to nullfys an entry in the skill_tree. ... An important check in all of the databases is the number of fields (columns) provided - with your suggestion, we'd have to remove that check. I understand your intent, and agree that it'd be convenient, but I still can't agree with it. You're trading a handful couple of conflict edits for tens of thousands of extra checks/operations each time every database loads. Quote Link to comment Share on other sites More sharing options...
sietse11 Posted January 4, 2014 Group: Members Topic Count: 44 Topics Per Day: 0.01 Content Count: 127 Reputation: 7 Joined: 02/10/13 Last Seen: February 1, 2019 Share Posted January 4, 2014 Point made Quote Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 5, 2014 Group: Members Topic Count: 218 Topics Per Day: 0.05 Content Count: 1180 Reputation: 141 Joined: 01/27/12 Last Seen: January 24, 2023 Author Share Posted January 5, 2014 I see what your saying, but that leads me to ask one question? Why do we have to remove that check? Can't we just modify to check for two conditons at the same time. I know src modification is different, but its seems kind of like scripting where you would use, if(one==1 || two==1) { }. Anyways, yea I wouldn't want to do anything to possibly overwork the server. Peopleperson49 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.